Fixes a lot of issues and upgrades to 3.4#34
Merged
Conversation
* support from source builds on all platforms. * pre-generated bindings using gen_bindings.sh script. And some manual bindings in `src/sys/manual.rs`. * built-time generated bindings using bindgen feature. * README updated and included in crate docs. * ported multi-window example from C to rust (from official glfw repo) * github workflow to check src/pre-built + shared/static builds. It also checks generating bindings at build time and verify that pre-generated bindings are same on different platforms. * change version to just be normal. * use edition 2021 because a bunch of code uses features from that edition.
Author
|
ping @bvssvni |
bvssvni
approved these changes
Apr 24, 2025
Author
|
I think we can publish this to crates.io, to prepare for glfw-rs release. |
This was referenced Apr 24, 2025
- skip layout tests in pre-generated bindings to avoid errors on emscripten - Test more build configuratioions in github CI - support using pkg-config to find glfw libs - properly document features/linker flags.
Author
|
Except for cross-compilation, I think this is more or less done. If there's any issues found, we can fix them later. @bvssvni can you publish this to crates.io, so that we can move PistonDevelopers/glfw-rs#589 forward? Or add me as maintainer on crates.io too if you don't have the time :) |
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
partially closes PistonDevelopers/glfw-rs#586
src/sys/manual.rs.GLFW_VERSION_*for the header orglfwGetVersionfunction for the linked/loaded library).