Skip to content

fix: [PPT-2355] Allow user deletion after signage use #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stakach merged 1 commit into from
Feb 2, 2026
Merged

fix: [PPT-2355] Allow user deletion after signage use #304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions migration/db/migrations/20260202100500000_fix_playlist_revisions_user_id_fk.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
-- +micrate Up
-- SQL in section 'Up' is executed when this migration is applied

ALTER TABLE playlist_revisions ALTER COLUMN user_id DROP NOT NULL;

-- +micrate Down
-- SQL section 'Down' is executed when this migration is rolled back

ALTER TABLE playlist_revisions ALTER COLUMN user_id SET NOT NULL;
13 changes: 13 additions & 0 deletions spec/playlist_revision_spec.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,5 +180,18 @@ module PlaceOS::Model
playlist.revisions.to_a.map(&.id).should eq [revision3.id, revision.id]
playlist.revision.id.should eq revision3.id
end
it "allows user deletion when linked to a revision" do
user = Generator.user.save!
revision = Generator.revision
revision.user = user
revision.save!

# Should not raise foreign key constraint error
user.delete

# Verify nullification
reloaded = Playlist::Revision.find(revision.id.as(String))
reloaded.user_id.should be_nil
end
end
end
Loading