exporter: don't use errgroup.WithContext()#35
Open
omar-polo wants to merge 1 commit into
Open
Conversation
the returned context is a child of the one we pass, except that it cancel itself when 1) a function ran with g.Go() returns an error or 2) when g.Wait() gets called. Now, none of these two situations could happen, so remove one level of context chaining for semplification.
There was a problem hiding this comment.
Pull request overview
Removes unnecessary context chaining in the filesystem exporter by switching from errgroup.WithContext(ctx) to a plain errgroup.Group, since the derived context was not used for cancellation semantics in this implementation.
Changes:
- Replace
errgroup.WithContext(ctx)withvar g errgroup.GroupinFSExporter.Export. - Keep existing concurrency limiting via
g.SetLimit(p.opts.MaxConcurrency).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the returned context is a child of the one we pass, except that it cancel itself when 1) a function ran with g.Go() returns an error or 2) when g.Wait() gets called.
Now, none of these two situations could happen, so remove one level of context chaining for semplification.