export: fix Lutimes on windows#38
Open
omar-polo wants to merge 2 commits into
Open
Conversation
On windows it's not possible to get a handle on a directory like it's possible to get a file descriptor on unix: FILE_FLAG_BACKUP_SEMANTICS is required for getting handles on directories. Unfortunately, windows.Open, which is a wrapper around windows.CreateFile, passes other flags that override FILE_FLAG_BACKUP_SEMANTICS, so use CreateFile directly. FILE_FLAG_BACKUP_SEMANTICS is also safe to use on files. c.f. https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilew
mathieu-plak
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On windows it's not possible to get a handle on a directory like it's possible to get a file descriptor on unix: FILE_FLAG_BACKUP_SEMANTICS is required for getting handles on directories.
Unfortunately, windows.Open, which is a wrapper around windows.CreateFile, passes other flags that override FILE_FLAG_BACKUP_SEMANTICS, so use CreateFile directly.
FILE_FLAG_BACKUP_SEMANTICS is also safe to use on files.
c.f. https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilew