fix(perps): enforce native equity health on withdrawals#141
Draft
rndrntwrk wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the native perps health-check issue found during the contract audit.
Before this patch,
AgentPerpEngineNativechecked leverage using raw margin only. After an adverse oracle move, a position could have negative equity while still passing the rawnotional / margincheck, andwithdrawMargin()did not sync the oracle before evaluating the withdrawal.This patch brings the native health gate in line with the ERC20 engine: health is evaluated against equity, where
equity = margin + unrealizedPnl.Security Impact
equity <= 0.notional / equity, notnotional / raw margin.withdrawMargin()now requires a live market, syncs the oracle, settles funding, subtracts the withdrawal, then checks equity before sending ETH.modifyPosition()uses the same equity-aware health gate after position changes.Verification
testNativeWithdrawMarginRejectsNegativeEquityAfterOracleMovefailed because the withdrawal did not revert.env FOUNDRY_LIBS='["../../node_modules","lib"]' forge test --match-path test/perps/AgentPerpEngine.t.sol --match-test testNativeWithdrawMarginRejectsNegativeEquityAfterOracleMove-> 1 passed, 0 failedenv FOUNDRY_LIBS='["../../node_modules","lib"]' forge test --match-path test/perps/AgentPerpEngine.t.sol-> 49 passed, 0 failedenv FOUNDRY_LIBS='["../../node_modules","lib"]' forge test --match-path test/perps/AgentPerpEngineFuzz.t.sol-> 2 passed, 0 failedenv FOUNDRY_LIBS='["../../node_modules","lib"]' forge test --match-path test/adversarial/PmPerpsAdversarial.t.sol-> 11 passed, 0 failedgit diff --check-> passStaging Policy
This PR targets
mainand is intentionally draft while review is pending. The same patch will be replayed intoenoomian/stagingfor staging deployment and testing, but this effective PR remains open as the merge vehicle.Follow-up
This PR fixes the withdrawal/health-gate portion. The separate native liquidation accounting finding remains open because it requires PnL realization, insurance draw, and bad-debt accounting changes in the liquidation path.