Fix: force parameter names to lowercase to avoid SQLite duplicate column#1
Open
markuskjeldsen wants to merge 1 commit into
Open
Fix: force parameter names to lowercase to avoid SQLite duplicate column#1markuskjeldsen wants to merge 1 commit into
markuskjeldsen wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I got an error because apparently i have 2 'Operating Temperature' parameters in my partdb which gave the following error
Updating /home/markus/projects/partdb_odbc_sync/partdb.sqlite...
Traceback (most recent call last):
File "/home/markus/projects/partdb_odbc_sync/./sync_partdb.py", line 467, in
main()
File "/home/markus/projects/partdb_odbc_sync/./sync_partdb.py", line 449, in main
ensure_table(cur, table_name, all_columns)
File "/home/markus/projects/partdb_odbc_sync/./sync_partdb.py", line 263, in ensure_table
cur.execute(target_schema)
sqlite3.OperationalError: duplicate column name: Operating_temperature
this it can be fixed by forcing .lower() in the
def sanitize_column_name(name) function
Thank you for your work.
also feel free to reject this PR if you want capitalization