build: repin SDK at the retagged v0.18.0; restore two-arg PJ_DIALOG_PLUGIN#232
Merged
Conversation
…LUGIN Two leftovers from the #229/#230 merge race: - extern/plotjuggler_core -> 9def534, the RETAGGED v0.18.0 (#229 merged moments before the repin landed, so main pinned the pre-retag 7abaccb and missed the sort-key-aware table deltas, plotjuggler_sdk#154). SDK_VERSION already reads 0.18.0. - All 20 dialog registration sites back to the documented two-arg PJ_DIALOG_PLUGIN(Class, kManifest) form (+ docs). The WITH_MANIFEST spelling was a Windows workaround for the macro dispatch bug that v0.18.0 fixes (plotjuggler_sdk#153), so it is no longer needed now that main pins 0.18.0. Validated: fleet rebuilt against the retagged SDK (168/168), ctest 26/26 passed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two leftovers from the #229/#230 merge race, consolidated:
9def534, the retaggedv0.18.0. feat: typed sort keys for mcap/ulog tables + mosaico sort indicators #229 merged moments before the retag re-pin landed on its branch, somainpins the pre-retag7abaccband misses the sort-key-aware table deltas (plotjuggler_sdk#154).SDK_VERSIONalready reads0.18.0— this aligns the submodule with it.PJ_DIALOG_PLUGIN(Class, kManifest)form (+CLAUDE.md/porting_guide.md). TheWITH_MANIFESTspelling merged via fix(streams): system_clock timestamps; dialog manifest + overload-guard consistency sweep #230 was a Windows workaround for the MSVC legacy-preprocessor dispatch bug thatv0.18.0fixes (plotjuggler_sdk#153); with main now on 0.18.0 it's no longer needed.Validation: stale 0.18.0 Conan package purged, SDK rebuilt from the retagged sources via
ensure_core.sh, fleet 168/168,ctest26/26.(Also cleaned up: the auto-deleted
feat/table-item-typed-valuesbranch my late push had resurrected.)🤖 Generated with Claude Code