fix: align PJ_PACKAGE_VERSION with 0.19.0#157
Merged
Conversation
… for DSO and static plugins A host that registers statically linked plugins has to decode their embedded manifests itself (no DSO scan runs), and a private decoder invited a second, weaker re-implementation host-side — letting a malformed static plugin pass validation the DSO path would reject. decodeManifest(source_path, family, manifest_json) is now part of the pj_plugins/host/plugin_catalog.hpp API: required non-empty id/name/version, typed-field rejection, and the message-parser encoding requirement, identically for both discovery paths. Additive; no ABI or protocol change. Version 0.19.0.
The CMake package version feeds write_basic_package_version_file and the conda-release version-agreement guard; conanfile.py, recipe.yaml, and the CHANGELOG already said 0.19.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.19.0 conda-release run failed its version-agreement guard: #156 bumped conanfile.py, recipe.yaml, and the CHANGELOG but missed the fourth version source — CMakeLists.txt's
PJ_PACKAGE_VERSION(baked into ConfigVersion.cmake). One line.After merging, re-run the release by moving the tag:
git tag -f v0.19.0 <merge-commit> && git push -f origin v0.19.0(the failed run consumed the old tag), or tag v0.19.1 if you prefer immutable tags.🤖 Generated with Claude Code