Replace deprecated facebook/pyre-action with direct Pyre execution in CI#2
Replace deprecated facebook/pyre-action with direct Pyre execution in CI#2Copilot wants to merge 3 commits into
facebook/pyre-action with direct Pyre execution in CI#2Conversation
facebook/pyre-action with direct Pyre execution in CI
|
or replacew blocks of adding modei,comute,snipper,programmic jsond fi!e on srver ? exhausive list server lik caddy deno supabas w llm? CHECK PINKVAI IN PINKYCOLLIE |
PR Summary by QodoRun Pyre directly in CI to avoid deprecated facebook/pyre-action dependencies
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
Code Review by Qodo
1. Code scanning output removed
|
| - name: Run Pyre | ||
| run: pyre check |
There was a problem hiding this comment.
1. Code scanning output removed 🐞 Bug ◔ Observability
The workflow still claims Code Scanning integration and grants security-events: write, but it now runs plain pyre check without generating/uploading SARIF, so no Pyre findings will appear in GitHub Code Scanning.
Agent Prompt
### Issue description
The workflow text/permissions indicate Code Scanning integration, but the job no longer produces or uploads SARIF after switching to direct `pyre check`, so Code Scanning will not receive results.
### Issue Context
This is a behavior regression from “Code Scanning workflow” semantics to a plain CI command.
### Fix Focus Areas
- .github/workflows/pyre.yml[6-8]
- .github/workflows/pyre.yml[30-34]
- .github/workflows/pyre.yml[53-54]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s Pyre GitHub Actions workflow to avoid the deprecated transitive dependency chain introduced by facebook/pyre-action, and instead installs/runs Pyre directly within the CI job.
Changes:
- Replaced
facebook/pyre-actionwithactions/setup-python@v5+ shell-based dependency installation. - Runs Pyre via
pyre checkdirectly in the workflow.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - name: Run Pyre | ||
| run: pyre check |
| if [ -f requirements.txt ]; then | ||
| pip install -r requirements.txt | ||
| fi |
The Pyre workflow was failing before analysis started because
facebook/pyre-actiontransitively depended on deprecatedactions/upload-artifact@v2, which GitHub now blocks. This change removes that dependency path and runs Pyre directly in the workflow.Workflow dependency path cleanup
facebook/pyre-action@60697a7858f7cc8470d8cc494a3cf2ad6b06560dfrom.github/workflows/pyre.yml.Direct Pyre setup/execution
actions/setup-python@v5with Python3.11.pip, optionalrequirements.txt,pyre-check).pyre check.Resulting CI behavior