Change the static global logger to be a UI-free logger #1063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mysticial
reviewed
Jan 20, 2026
Mysticial
reviewed
Jan 20, 2026
Mysticial
reviewed
Jan 20, 2026
|
|
||
| static FileLoggerConfig _global_logger_config; | ||
|
|
||
| void initialize_global_logger(FileLoggerConfig config){ |
Collaborator
There was a problem hiding this comment.
We need to be careful here that nothing calls the logger during static init.
Alternatively, you can make the entire logger lazy static init.
Collaborator
Author
There was a problem hiding this comment.
How can you do that? The logger object is already lazy static init but it needs to be set with a proper logger config, which I can only implement in this PR by calling initialize_global_logger() at start of main() to initialize a static config struct before any logger calls.
Gin890
force-pushed
the
global_file_logger
branch
from
3824e06 to
0100f8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The static global logger is now a FileLogger. The old GUI-dependent logger, FileWindowLogger is removed. Each LogWindow is connected directly to the global FileLogger.