Merged
Conversation
- Add FileType parameter to GetZarrSpecToWrite() for v2/v3 switching - Add GetZarrV3DataType() for plain dtype names (uint16 vs <u2) - Add FileType parameter to TsWriterCPP constructor (defaults to v2) - Update Python bindings and wrapper to expose file_type parameter Zarr v3 writes create zarr.json with zarr_format:3, v2 backwards compatible. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- test_write_zarr_v3_basic: Basic v3 write and read-back verification - test_write_zarr_v3_multiple_dtypes: Test uint8, uint16, uint32, float32 - test_write_zarr_v3_chunked: Chunked writes with 2x2 grid pattern - test_write_zarr_v2_default: Verify default FileType is still v2 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Move FileType enum definition from tsreader.h to utilities.h - tsreader.h now includes utilities.h instead of defining FileType - tswriter.h now includes utilities.h instead of tsreader.h - Remove unused headers from tsreader.h (iostream, tuple, unordered_map) This centralizes the FileType enum and reduces unnecessary header dependencies. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
FileType is now defined in utilities.h, so this include is no longer needed. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.