Skip to content

fix: ensure workflows checkout exact tag for clean version detection #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sameeul wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: ensure workflows checkout exact tag for clean version detection #110

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions .github/workflows/publish_pypi.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ jobs:
- uses: actions/checkout@v3
name: Check out
with:
ref: ${{ github.ref }} # Explicitly checkout the triggering ref (tag)
fetch-depth: 0 # Fetch all history for setuptools-scm
fetch-tags: true # Explicitly fetch tags

Expand All @@ -37,6 +38,14 @@ jobs:
with:
python-version: '3.11'

- name: Verify git state
run: |
echo "Git ref: ${{ github.ref }}"
echo "Git ref name: ${{ github.ref_name }}"
git describe --tags --exact-match 2>/dev/null && echo "✅ On exact tag" || echo "⚠️ Not on exact tag"
git describe --tags --long
shell: bash

- name: Update version files
run: |
python -m pip install setuptools-scm
Expand All @@ -48,6 +57,9 @@ jobs:
else
python scripts/update_versions.py
fi
# Verify setuptools-scm version detection
echo "setuptools-scm detects version:"
python -m setuptools_scm
shell: bash

- name: Install cibuildwheel
Expand Down Expand Up @@ -104,6 +116,7 @@ jobs:
- uses: actions/checkout@v3
name: Check out
with:
ref: ${{ github.ref }} # Explicitly checkout the triggering ref (tag)
fetch-depth: 0 # Fetch all history for setuptools-scm
fetch-tags: true # Explicitly fetch tags

Expand All @@ -119,6 +132,14 @@ jobs:
with:
python-version: '3.11'

- name: Verify git state
run: |
echo "Git ref: ${{ github.ref }}"
echo "Git ref name: ${{ github.ref_name }}"
git describe --tags --exact-match 2>/dev/null && echo "✅ On exact tag" || echo "⚠️ Not on exact tag"
git describe --tags --long
shell: bash

- name: Update version files
run: |
python -m pip install setuptools-scm
Expand All @@ -130,6 +151,9 @@ jobs:
else
python scripts/update_versions.py
fi
# Verify setuptools-scm version detection
echo "setuptools-scm detects version:"
python -m setuptools_scm
shell: bash

- name: Install cibuildwheel
Expand Down
Loading