Conversation
LTMeyer
changed the title
- Replace global state manipulation with thread-safe context manager - Add comprehensive modality validation in from_pretrained method - Fix save_pretrained method to handle modality parameter properly - Simplify modality hierarchy by merging BaseModality and Modality classes - Remove duplicate NewImageCodec class - Improve error handling and type safety 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Remove redundant Modality inheritance from all scalar modality classes. Since Scalar already inherits from Modality, the dual inheritance (Scalar, Modality) was unnecessary and has been simplified to (Scalar). This affects all scalar modalities including: - Legacy Survey flux measurements (G, R, I, Z, W1-W4) - Shape parameters (R, E1, E2) - HSC magnitudes and extinction values - Gaia flux measurements and parallax - Coordinate modalities (Ra, Dec) - Spectral coefficients (GaiaXpBp, GaiaXpRp) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #29
This PR adds the
PytorchCodecHubMixinto be able to load and save codecs in the same model repo as AION.Upload Codec Model to HF
Once the class inherits from this new Mixin, the following will upload the codec as a regular model, except that instead of having its own model repo it will now be stored under
<model_repo>/codecs/<modality.name>of themodel_repo.Load Codec Model from HF
To load the model from HF, one has to specify the modality.
ToDo
If the design seems good to you, it remains to:
PytorchHubMixintoPytorchCodecHubMixinCheck modality validity(addressed in Small Refactor #31)Note that the question of different versions of AION is not addressed with this PR.