Rework bower.json#33
Open
FluorescentHallucinogen wants to merge 5 commits intoPolymerElements:masterfrom
Open
Conversation
Contributor
Author
* Remove `version` field in `bower.json` file, because it's deprecated and ignored by Bower (https://github.com/bower/spec/blob/master/json.md#version). * Add `polymer-element`, `polymer-2` and `polymer-2-hybrid` keywords to `bower.json` file to indicate that this is Polymer 1.x/2.x hybrid element.
Contributor
Author
|
@cdata Please merge this pull request. |
Contributor
|
Thanks @FluorescentHallucinogen . Can you make a separate PR just fixing the |
Contributor
Author
Contributor
|
@FluorescentHallucinogen because this PR conflates multiple changes that would be better to consider separately. |
cdata
suggested changes
Mar 21, 2018
Contributor
cdata
left a comment
cdata
left a comment
There was a problem hiding this comment.
Please change this PR to only contain the polyfill fix, and open additional PRs for each discrete change that you think should also be made. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.