-
Notifications
You must be signed in to change notification settings - Fork 65
Adding a workflow to run v4 storage rust tests automatically and flesh out assert_valid_graph #2437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
arienandalibi
wants to merge
6
commits into
db_v4
Choose a base branch
from
db_v4_assert_valid
base: db_v4
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing/loading from parquet (roundtrip).
…ral props obtained from fixture.
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: 520ea68 | Previous: fee2452 | Ratio |
|---|---|---|---|
large/1k fixed edge updates with varying time and numeric string input |
774215 ns/iter (± 6058) |
368478 ns/iter (± 1340) |
2.10 |
lotr_graph/num_edges |
5 ns/iter (± 0) |
0 ns/iter (± 0) |
+∞ |
lotr_graph/num_nodes |
419 ns/iter (± 1) |
1 ns/iter (± 0) |
419 |
lotr_graph/iterate nodes |
5876 ns/iter (± 23) |
1832 ns/iter (± 3) |
3.21 |
lotr_graph_materialise/materialize |
9411932 ns/iter (± 89615) |
1504850 ns/iter (± 4769) |
6.25 |
lotr_graph_window_100/num_edges |
28 ns/iter (± 0) |
9 ns/iter (± 0) |
3.11 |
lotr_graph_window_100/num_nodes |
446 ns/iter (± 1) |
5 ns/iter (± 0) |
89.20 |
lotr_graph_window_100/iterate nodes |
10095 ns/iter (± 27) |
4390 ns/iter (± 18) |
2.30 |
lotr_graph_window_100_materialise/materialize |
9624792 ns/iter (± 424302) |
1657087 ns/iter (± 8059) |
5.81 |
lotr_graph_window_10/iterate nodes |
35080 ns/iter (± 108) |
10626 ns/iter (± 20) |
3.30 |
lotr_graph_window_10/iterate edges |
105970 ns/iter (± 506) |
44324 ns/iter (± 404) |
2.39 |
lotr_graph_window_10_materialise/materialize |
6134175 ns/iter (± 136985) |
1018727 ns/iter (± 3350) |
6.02 |
lotr_graph_subgraph_10pc/has_edge_existing |
509 ns/iter (± 4) |
87 ns/iter (± 0) |
5.85 |
lotr_graph_subgraph_10pc/num_nodes |
332 ns/iter (± 2) |
4 ns/iter (± 0) |
83 |
lotr_graph_subgraph_10pc/has_node_existing |
232 ns/iter (± 3) |
36 ns/iter (± 0) |
6.44 |
lotr_graph_subgraph_10pc/iterate nodes |
4765 ns/iter (± 10) |
811 ns/iter (± 2) |
5.88 |
lotr_graph_subgraph_10pc_windowed/has_node_existing |
131 ns/iter (± 8) |
60 ns/iter (± 15) |
2.18 |
lotr_graph_subgraph_10pc_windowed/iterate nodes |
4640 ns/iter (± 8) |
1348 ns/iter (± 3) |
3.44 |
lotr_graph_window_50_layered/num_edges |
79502 ns/iter (± 1329) |
39405 ns/iter (± 795) |
2.02 |
lotr_graph_window_50_layered/num_nodes |
105086 ns/iter (± 1768) |
22581 ns/iter (± 6999) |
4.65 |
lotr_graph_window_50_layered/has_node_existing |
1456 ns/iter (± 209) |
136 ns/iter (± 10) |
10.71 |
lotr_graph_window_50_layered/max_id |
117619 ns/iter (± 8150) |
28320 ns/iter (± 700) |
4.15 |
lotr_graph_window_50_layered/max_degree |
2040035 ns/iter (± 17910) |
300063 ns/iter (± 15681) |
6.80 |
lotr_graph_window_50_layered/iterate nodes |
241262 ns/iter (± 1166) |
17808 ns/iter (± 40) |
13.55 |
lotr_graph_window_50_layered/iterate edges |
222404 ns/iter (± 650) |
87960 ns/iter (± 265) |
2.53 |
lotr_graph_window_50_layered/max_neighbour_degree |
3701332 ns/iter (± 12059) |
391592 ns/iter (± 1308) |
9.45 |
lotr_graph_window_50_layered_materialise/materialize |
20448325 ns/iter (± 313884) |
3412901 ns/iter (± 18841) |
5.99 |
lotr_graph_persistent_window_50_layered/num_edges_temporal |
582823 ns/iter (± 2926) |
209279 ns/iter (± 2093) |
2.78 |
lotr_graph_persistent_window_50_layered/has_edge_existing |
238 ns/iter (± 105) |
118 ns/iter (± 21) |
2.02 |
lotr_graph_persistent_window_50_layered/num_nodes |
140360 ns/iter (± 3420) |
33133 ns/iter (± 2137) |
4.24 |
lotr_graph_persistent_window_50_layered/has_node_existing |
1674 ns/iter (± 444) |
174 ns/iter (± 78) |
9.62 |
lotr_graph_persistent_window_50_layered/max_id |
153342 ns/iter (± 6023) |
40520 ns/iter (± 1918) |
3.78 |
lotr_graph_persistent_window_50_layered/max_degree |
2824308 ns/iter (± 17797) |
458401 ns/iter (± 9395) |
6.16 |
lotr_graph_persistent_window_50_layered/iterate nodes |
324379 ns/iter (± 1052) |
34953 ns/iter (± 148) |
9.28 |
lotr_graph_persistent_window_50_layered/max_neighbour_degree |
5138228 ns/iter (± 14304) |
510515 ns/iter (± 2399) |
10.06 |
lotr_graph_persistent_window_50_layered_materialise/materialize |
48774165 ns/iter (± 1420375) |
5164597 ns/iter (± 45701) |
9.44 |
lotr_graph/proto_decode |
9792645 ns/iter (± 98199) |
1943412 ns/iter (± 27965) |
5.04 |
lotr_graph/proto_encode |
9288986 ns/iter (± 72645) |
1272567 ns/iter (± 81561) |
7.30 |
This comment was automatically generated by workflow using github-action-benchmark.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.