Uniquely identify sound devices on Windows#1160
Open
bear101 wants to merge 2 commits into
Open
Conversation
If a user unplugs a USB headset and plugs it into another USB port then the sound device may get a new PaDeviceIndex, i.e. we cannot use PaDeviceIndex to identify a sound device. With this change a sound device (PaDeviceInfo) can be uniquely identified after a Pa_Terminate()/Pa_Initialize(). So far only Windows is supported (using the sound device's GUID).
philburk
reviewed
Jul 2, 2026
| PaTime defaultHighOutputLatency; | ||
|
|
||
| double defaultSampleRate; | ||
| const char* uniqueID; |
Collaborator
There was a problem hiding this comment.
This is an API change so it cannot go into V19.
We can discuss this for V20.
Changing structure sizes can break code, even with the structure version. Adding an additional function might be safer.
Collaborator
|
CI is failing with: D:/a/_temp/msys64/ucrt64/bin/../lib/gcc/x86_64-w64-mingw32/16.1.0/../../../../x86_64-w64-mingw32/bin/ld.exe: src/hostapi/wmme/.libs/pa_win_wmme.o:pa_win_wmme.c:(.rdata$.refptr.GUID_NULL[.refptr.GUID_NULL]+0x0): undefined reference to `GUID_NULL' I recommend creating an Issue. We need to discuss the problem before we can consider the possible solutions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a user unplugs a USB headset and plugs it into another USB port then the sound device may get a new PaDeviceIndex, i.e. we cannot use PaDeviceIndex to identify a sound device.
With this change a sound device (PaDeviceInfo) can be uniquely identified after a Pa_Terminate()/Pa_Initialize().
So far only Windows is supported (using the sound device's GUID).