test: -cluster @absent narrowly satisfies only the missing cluster#128
Merged
Conversation
Add a manifest-driven-mode regression test proving that -cluster NAME=@absent is not a blanket skip: a proxy into the absent cluster passes, while every other problem is still reported — a remote missing from a mapped cluster and a broken view source both surface, and the valid proxy resolves. Exactly the two real problems are found, nothing more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Locks down that
-cluster NAME=@absentis narrow, not a blanket skip — it satisfies references into that one missing cluster while every other problem is still caught.Scenario (manifest-driven mode)
A
datarole with four objects, validated with-cluster events_recent=@absent:web_statsaux/sharded_web_stats(declared)events_recentevents_recent(@absent)web_stats_goneaux/sharded_gone(missing)brokenviewposthog.nonexistentAsserts the two real problems (
sharded_gone,nonexistent) are reported, the@absentproxy and the validauxproxy are not, anddatahas exactly 2 errors — while theauxrole stays clean.Test-only; full suite green,
go vet+gofmtclean.