fix: show full file path in edit tool view#1599
Conversation
FileMentionChip now displays the relative directory path (muted) before the filename, so users can see which file was edited at a glance without expanding the diff. Before: 📄 ActionSelector.tsx After: 📄 src/renderer/components/action-selector/ActionSelector.tsx The directory portion uses text-gray-9 for visual hierarchy, keeping the filename prominent. Fixes PostHog#1194
| > | ||
| <Text size="1"> | ||
| <FileIcon filename={filename} size={12} /> | ||
| {directory && ( |
There was a problem hiding this comment.
tiny nitpick: there is a bit of a gap between the two spans now, can we tighten that up a bit please?
adboio
left a comment
adboio
left a comment
There was a problem hiding this comment.
left a small comment, otherwise looks great :)
Wrap directory and filename in a single span to eliminate whitespace gap between them.
|
Good catch! Tightened the spacing by wrapping directory and filename in a single span. Pushed the fix 👍 |
Use inline-flex on the wrapper span to collapse whitespace text nodes between directory and filename, eliminating the visible gap.
Visual EvidenceBefore → After: Full file path shown in edit tool view
The directory portion is shown in muted gray ( |
|
Good catch — tightened the gap between the icon and filename ( |
|
@adboio thanks for catching that! Tightened up the gap by putting the spans on one line and adding gap-0 to the inline-flex container. Also removed all unrelated changes — the PR now only touches FileMentionChip.tsx. |
adboio
left a comment
adboio
left a comment
There was a problem hiding this comment.
thanks for fixing!! can you please just remove the .github/evidence from the commit? i'll get this merged asap :)
Reorders FileMentionChip so the bold filename renders before the gray directory path, matching the diff panel header style. Directory truncates with an ellipsis on overflow while the filename stays visible in full. Nudges the whole chip down 1px and uses inline-flex with baseline alignment so it sits cleanly inline with surrounding text. Also restores .gitignore entries and removes the PR evidence image that leaked onto the branch. Generated-By: PostHog Code Task-Id: 97371512-63be-4a27-be52-b007a53795a4
Adds flex sizing and overflow containment so the chip shrinks to its parent's width and the directory path clips with an ellipsis when there isn't enough room, instead of pushing layout. Generated-By: PostHog Code Task-Id: 97371512-63be-4a27-be52-b007a53795a4
I've put the file name in front since it's more readable this way. |
4 participants
Problem
When the agent edits a file, the edit tool view only shows the filename (e.g.
ActionSelector.tsx), not the full path. When working across many files with the same name in different directories, this makes it hard to know which file was changed.Fixes #1194
Solution
Updated
FileMentionChipto show the relative directory path before the filename:📄 ActionSelector.tsx📄 src/renderer/components/action-selector/ActionSelector.tsxThe directory portion uses
text-gray-9(muted) for visual hierarchy, keeping the filename prominent. Uses the existingtoRelativePathutility already in the same file.Files Changed
apps/code/src/renderer/features/sessions/components/session-update/FileMentionChip.tsx— 9 lines added