feat(sig): Add user autonomy config, refactor API#1672
Conversation
oliverb123
force-pushed
the
sig/api-overhaul
branch
from
3d57ae5 to
7972ab1
Compare
oliverb123
force-pushed
the
sig/api-overhaul
branch
from
7ca6457 to
3373877
Compare
|
@copilot resolve the merge conflicts in this pull request |
# Conflicts: # apps/code/src/renderer/features/inbox/components/SignalSourceToggles.tsx Co-authored-by: oliverb123 <8105072+oliverb123@users.noreply.github.com>
Resolved in Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Twixes
left a comment
Twixes
left a comment
There was a problem hiding this comment.
Looks like a bad merge in one spot
| {sourceProductMeta && ( | ||
| <Tooltip content={sourceProductMeta.label}> | ||
| <span | ||
| style={{ color: sourceProductMeta.color }} | ||
| className="shrink-0 pt-1" | ||
| > | ||
| <sourceProductMeta.Icon size={12} /> | ||
| </span> | ||
| </Tooltip> | ||
| )} |
There was a problem hiding this comment.
I actually think we should bring back source_products on the report API, but okay to remove the dead Code code in the meantime
There was a problem hiding this comment.
Looking at the API refactor in posthog, failing to see where I removed that?
There was a problem hiding this comment.
I was being unclear, you didn't. I did. 😄 That never made into the API, because my initial implementation wasn't right perf-wise. It did land in Code as part of another PR though. So I meant: We should actually implement it properly
There was a problem hiding this comment.
Ah - yeah I was going to say hitting CH feels expensive. We could compute this on the fly during signal ingestion, and store it either on the report or in artefacts. Agreed we should do it eventually.
…is status Added back CircleNotchIcon import, SignalSourceConfig type import, SourceRunningIndicator component, and sessionAnalysisStatus prop that were lost during prior edits. Generated-By: PostHog Code Task-Id: e675d79b-84e1-4147-9538-0603322f1fb0
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: oliverb123 <8105072+oliverb123@users.noreply.github.com>
Depends on PostHog/posthog#54056