Skip to content

Properly handle origin === "signal_report" #1709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Twixes merged 2 commits into from
Apr 17, 2026
Merged

Properly handle origin === "signal_report" #1709

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dfe6766
Properly handle origin === "signal_report"
Twixes Apr 17, 2026
a1bb7b0
Fix packages/agent/src/test/mocks/claude-sdk.ts
Twixes Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/agent/src/server/agent-server.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,6 +489,16 @@ describe("AgentServer HTTP Mode", () => {
delete process.env.POSTHOG_CODE_INTERACTION_ORIGIN;
});

it("returns auto-PR prompt for signal_report-origin runs", () => {
process.env.POSTHOG_CODE_INTERACTION_ORIGIN = "signal_report";
const s = createServer();
const prompt = (s as unknown as TestableServer).buildCloudSystemPrompt();
expect(prompt).toContain("posthog-code/");
expect(prompt).toContain("Create a draft pull request");
expect(prompt).toContain("gh pr create --draft");
delete process.env.POSTHOG_CODE_INTERACTION_ORIGIN;
});

it("returns PR-update prompt for existing PRs on Slack-origin runs", () => {
process.env.POSTHOG_CODE_INTERACTION_ORIGIN = "slack";
const s = createServer();
Expand Down
5 changes: 3 additions & 2 deletions packages/agent/src/server/agent-server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1265,13 +1265,14 @@ export class AgentServer {
}

/**
* Slack-origin cloud runs auto-publish by default. Every other origin is
* Automated-origin cloud runs auto-publish by default. Every other origin is
* review-first unless the user explicitly asks, and createPr=false always
* disables publishing.
*/
private shouldAutoPublishCloudChanges(): boolean {
const origin = this.getCloudInteractionOrigin();
return (
this.getCloudInteractionOrigin() === "slack" &&
(origin === "slack" || origin === "signal_report") &&
this.config.createPr !== false
);
}
Expand Down
Loading