fix(cloud-agent): serialize concurrent codex prompts to fix usage accounting#1721
Merged
Conversation
Contributor
Author
This was referenced Apr 17, 2026
463eb7f to
bfbea4d
Compare
9e6b0fb to
0b35e19
Compare
joshsny
approved these changes
Apr 20, 2026
bfbea4d to
f00c114
Compare
0b35e19 to
7321bd4
Compare
65f3732 to
4fee8b5
Compare
7321bd4 to
3af3e64
Compare
4fee8b5 to
99ebc97
Compare
3af3e64 to
229deb0
Compare
229deb0 to
1ba067c
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem
codex-acp and codex-rs serialize submissions at the conversation level, so concurrent prompts are safe from codex's perspective. But our adapter accumulates per-turn usage into
sessionState.accumulatedUsagevia the codex-clientsessionUpdatehandler, and eachprompt()starts withresetUsage(). If two prompts run concurrently on the JS side — e.g. two concurrent/commandPOSTs (a Slack follow-up racing a web-UI follow-up, or a retry after an HTTP timeout) — the second prompt'sresetUsagewipes the first's in-flight counters and bothTURN_COMPLETEnotifications report garbled totals.Changes
Chain
CodexAcpAgent.promptcalls through a FIFO promise mutex so the usage accumulator has a single owner per turn. Errors on one prompt do not block subsequent prompts (.catch(() => {})on the previous tail).How did you test this?
prompt()calls serialize — the second does not invokecodexConnection.promptuntil the first resolves.@posthog/agentsuite green (263 tests).