Skip to content

feat(code): fix flakey tesk#2052

Merged
k11kirky merged 1 commit into
mainfrom
05-06-feat_code_fix_flakey_tesk
May 6, 2026
Merged

feat(code): fix flakey tesk#2052
k11kirky merged 1 commit into
mainfrom
05-06-feat_code_fix_flakey_tesk

Conversation

@k11kirky
Copy link
Copy Markdown
Contributor

@k11kirky k11kirky commented May 6, 2026

Problem

The SSE keepalive test was intermittently hanging or failing because the setInterval mock was replacing all interval timers globally, including those used internally by undici, the HTTP server, and MSW. Without their periodic callbacks, those internals would stall and cause the test to hang.

Changes

  • The setInterval spy now passes non-keepalive timers through to the real setInterval, so only the SSE keepalive interval is intercepted and captured.
  • Increased the vi.waitFor timeout to 10 seconds with a 50ms polling interval to give the keepalive callback more time to register reliably.
  • Increased the read loop attempts from 5 to 10 to allow more time for SSE data to arrive.
  • Increased the overall test timeout from 20 to 30 seconds to accommodate the more lenient waiting behavior.

Copy link
Copy Markdown
Contributor Author

k11kirky commented May 6, 2026

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 6, 2026

Reviews (1): Last reviewed commit: "feat(code): fix flakey tesk" | Re-trigger Greptile

Copy link
Copy Markdown
Contributor Author

k11kirky commented May 6, 2026

Merge activity

  • May 6, 4:56 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • May 6, 4:58 PM UTC: Graphite rebased this pull request as part of a merge.
  • May 6, 5:07 PM UTC: @k11kirky merged this pull request with Graphite.

@k11kirky k11kirky changed the base branch from 05-06-feat_code_unify_git_integration_to_use_git_store_and_always_use_new_git_user_integration to graphite-base/2052 May 6, 2026 16:57
@k11kirky k11kirky changed the base branch from graphite-base/2052 to main May 6, 2026 16:57
@k11kirky k11kirky force-pushed the 05-06-feat_code_fix_flakey_tesk branch from 30354d4 to de829ff Compare May 6, 2026 16:57
@k11kirky k11kirky merged commit 885512b into main May 6, 2026
16 checks passed
@k11kirky k11kirky deleted the 05-06-feat_code_fix_flakey_tesk branch May 6, 2026 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants