feat(code): fix flakey tesk#2052
Merged
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
|
Reviews (1): Last reviewed commit: "feat(code): fix flakey tesk" | Re-trigger Greptile |
jonathanlab
approved these changes
May 6, 2026
jonathanlab
approved these changes
May 6, 2026
Contributor
Author
30354d4 to
de829ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem
The SSE keepalive test was intermittently hanging or failing because the
setIntervalmock was replacing all interval timers globally, including those used internally by undici, the HTTP server, and MSW. Without their periodic callbacks, those internals would stall and cause the test to hang.Changes
setIntervalspy now passes non-keepalive timers through to the realsetInterval, so only the SSE keepalive interval is intercepted and captured.vi.waitFortimeout to 10 seconds with a 50ms polling interval to give the keepalive callback more time to register reliably.