feat(inbox): include linear id in data source creation#2108
Merged
jonathanlab merged 1 commit intoMay 8, 2026
Conversation
Generated-By: PostHog Code Task-Id: 341ea6f2-0b64-43eb-9761-cca8612c0141
This was referenced May 8, 2026
Contributor
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
apps/code/src/renderer/features/inbox/components/DataSourceSetup.tsx:289-291
The type assertion here is unsound — the `find` callback's element is typed as `{ kind: string }`, which is then cast to the unrelated `{ id: number | string } | undefined`. If the API response shape ever changes, TypeScript won't catch the breakage. Better to widen the callback type to include `id` so that the property access is verified rather than assumed.
```suggestion
const linearIntegration = integrations.find(
(i: { kind: string; id: number | string }) => i.kind === "linear",
);
```
Reviews (1): Last reviewed commit: "feat(inbox): include linear id in data s..." | Re-trigger Greptile |
andrewm4894
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were not passing our
linear_integration_idinto the external data source create call, causing it to fail and Linear integrations to not work.Closes #1495
Closes #2005
https://discord.com/channels/1465397904901673123/1465397906977849612/1501995293884022795
https://posthog.slack.com/archives/C09G8Q32R6F/p1778194129515839
Created with PostHog Code