Skip to content

feat(inbox): include linear id in data source creation#2108

Merged
jonathanlab merged 1 commit into
mainfrom
posthog-code/fix-linear-integration-connection-issue
May 8, 2026
Merged

feat(inbox): include linear id in data source creation#2108
jonathanlab merged 1 commit into
mainfrom
posthog-code/fix-linear-integration-connection-issue

Conversation

@jonathanlab
Copy link
Copy Markdown
Contributor

We were not passing our linear_integration_id into the external data source create call, causing it to fail and Linear integrations to not work.

Closes #1495
Closes #2005
https://discord.com/channels/1465397904901673123/1465397906977849612/1501995293884022795
https://posthog.slack.com/archives/C09G8Q32R6F/p1778194129515839


Created with PostHog Code

Generated-By: PostHog Code
Task-Id: 341ea6f2-0b64-43eb-9761-cca8612c0141
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 8, 2026

Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
apps/code/src/renderer/features/inbox/components/DataSourceSetup.tsx:289-291
The type assertion here is unsound — the `find` callback's element is typed as `{ kind: string }`, which is then cast to the unrelated `{ id: number | string } | undefined`. If the API response shape ever changes, TypeScript won't catch the breakage. Better to widen the callback type to include `id` so that the property access is verified rather than assumed.

```suggestion
          const linearIntegration = integrations.find(
            (i: { kind: string; id: number | string }) => i.kind === "linear",
          );
```

Reviews (1): Last reviewed commit: "feat(inbox): include linear id in data s..." | Re-trigger Greptile

@jonathanlab jonathanlab added the Create Release This will trigger a new release label May 8, 2026
@jonathanlab jonathanlab merged commit 27d8207 into main May 8, 2026
15 checks passed
@jonathanlab jonathanlab deleted the posthog-code/fix-linear-integration-connection-issue branch May 8, 2026 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Create Release This will trigger a new release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to connect default Linear integration as a source for Inbox Adding Linear as a signal source does not work

2 participants