chat banner entry point#2128
Closed
cleo-pleurodon wants to merge 2 commits into
Closed
Conversation
Contributor
Prompt To Fix All With AIFix the following 2 code review issues. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 2
apps/code/src/renderer/features/sessions/components/TryInPostHogWorkBanner.tsx:34-36
**"Try in PostHog Work" button is non-functional**
The primary CTA button has no `onClick` handler, so clicking it does nothing. For a feature explicitly described as an "entry point to PostHog Work," this means the banner shows up but the main action it advertises can never be triggered.
### Issue 2 of 2
apps/code/src/renderer/features/sessions/components/SessionView.tsx:253-270
**Duplicated banner logic violates OnceAndOnlyOnce**
The same four state values (`showPostHogWorkBanner`, `postHogWorkBannerDismissed`) plus `handlePromptTextChange` and `handleDismissPostHogWorkBanner` — including the hardcoded `/pineapple/i` trigger — are copied verbatim into `TaskInput.tsx`. Any change to the trigger word or show/hide logic must be made in two places. Extracting a `usePostHogWorkBanner()` hook would keep this in one place.
Reviews (1): Last reviewed commit: "chat banner entry point" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+34
to
+36
| <Button size="2" variant="solid" color="gray" highContrast> | ||
| <Text className="px-2 text-[12px]">Try in PostHog Work</Text> | ||
| </Button> |
Contributor
There was a problem hiding this comment.
The primary CTA button has no onClick handler, so clicking it does nothing. For a feature explicitly described as an "entry point to PostHog Work," this means the banner shows up but the main action it advertises can never be triggered.
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/code/src/renderer/features/sessions/components/TryInPostHogWorkBanner.tsx
Line: 34-36
Comment:
**"Try in PostHog Work" button is non-functional**
The primary CTA button has no `onClick` handler, so clicking it does nothing. For a feature explicitly described as an "entry point to PostHog Work," this means the banner shows up but the main action it advertises can never be triggered.
How can I resolve this? If you propose a fix, please make it concise.
Comment on lines
253
to
+270
| const [isDraggingFile, setIsDraggingFile] = useState(false); | ||
| const [showPostHogWorkBanner, setShowPostHogWorkBanner] = useState(false); | ||
| const [postHogWorkBannerDismissed, setPostHogWorkBannerDismissed] = | ||
| useState(false); | ||
| const editorRef = useRef<PromptInputHandle>(null); | ||
| const dragCounterRef = useRef(0); | ||
|
|
||
| const handlePromptTextChange = useCallback( | ||
| (text: string) => { | ||
| if (postHogWorkBannerDismissed) return; | ||
| if (/pineapple/i.test(text)) { | ||
| setShowPostHogWorkBanner(true); | ||
| } | ||
| }, | ||
| [postHogWorkBannerDismissed], | ||
| ); | ||
|
|
||
| const handleDismissPostHogWorkBanner = useCallback(() => { |
Contributor
There was a problem hiding this comment.
The same four state values (showPostHogWorkBanner, postHogWorkBannerDismissed) plus handlePromptTextChange and handleDismissPostHogWorkBanner — including the hardcoded /pineapple/i trigger — are copied verbatim into TaskInput.tsx. Any change to the trigger word or show/hide logic must be made in two places. Extracting a usePostHogWorkBanner() hook would keep this in one place.
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/code/src/renderer/features/sessions/components/SessionView.tsx
Line: 253-270
Comment:
**Duplicated banner logic violates OnceAndOnlyOnce**
The same four state values (`showPostHogWorkBanner`, `postHogWorkBannerDismissed`) plus `handlePromptTextChange` and `handleDismissPostHogWorkBanner` — including the hardcoded `/pineapple/i` trigger — are copied verbatim into `TaskInput.tsx`. Any change to the trigger word or show/hide logic must be made in two places. Extracting a `usePostHogWorkBanner()` hook would keep this in one place.
How can I resolve this? If you propose a fix, please make it concise.
Introduces a top-level mode toggle above the nav list. Work mode is an empty shell — placeholder for an upcoming feature set built during the hackathon. Generated-By: PostHog Code Task-Id: bd0f6387-4ee8-42a4-b17d-80927d214463
Contributor
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
apps/code/src/renderer/features/sessions/components/SessionView.tsx:260-268
The banner stays visible after the trigger word is deleted from the input. Once "pineapple" is typed the banner appears, but if the user then edits the text to remove it the banner remains — there is no branch that sets `showPostHogWorkBanner` back to `false`. The same issue exists in `TaskInput.tsx`.
```suggestion
const handlePromptTextChange = useCallback(
(text: string) => {
if (postHogWorkBannerDismissed) return;
setShowPostHogWorkBanner(/pineapple/i.test(text));
},
[postHogWorkBannerDismissed],
);
```
Reviews (2): Last reviewed commit: "feat(code): add Code/Work mode switcher ..." | Re-trigger Greptile |
Comment on lines
+260
to
+268
| const handlePromptTextChange = useCallback( | ||
| (text: string) => { | ||
| if (postHogWorkBannerDismissed) return; | ||
| if (/pineapple/i.test(text)) { | ||
| setShowPostHogWorkBanner(true); | ||
| } | ||
| }, | ||
| [postHogWorkBannerDismissed], | ||
| ); |
Contributor
There was a problem hiding this comment.
showPostHogWorkBanner back to false. The same issue exists in TaskInput.tsx.
Suggested change
| const handlePromptTextChange = useCallback( | |
| (text: string) => { | |
| if (postHogWorkBannerDismissed) return; | |
| if (/pineapple/i.test(text)) { | |
| setShowPostHogWorkBanner(true); | |
| } | |
| }, | |
| [postHogWorkBannerDismissed], | |
| ); | |
| const handlePromptTextChange = useCallback( | |
| (text: string) => { | |
| if (postHogWorkBannerDismissed) return; | |
| setShowPostHogWorkBanner(/pineapple/i.test(text)); | |
| }, | |
| [postHogWorkBannerDismissed], | |
| ); |
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/code/src/renderer/features/sessions/components/SessionView.tsx
Line: 260-268
Comment:
The banner stays visible after the trigger word is deleted from the input. Once "pineapple" is typed the banner appears, but if the user then edits the text to remove it the banner remains — there is no branch that sets `showPostHogWorkBanner` back to `false`. The same issue exists in `TaskInput.tsx`.
```suggestion
const handlePromptTextChange = useCallback(
(text: string) => {
if (postHogWorkBannerDismissed) return;
setShowPostHogWorkBanner(/pineapple/i.test(text));
},
[postHogWorkBannerDismissed],
);
```
How can I resolve this? If you propose a fix, please make it concise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HACKATHON