fix(terminal): focus xterm on first click and on attach

[posthog]

Summary

James reported that clicking into the terminal didn't put the cursor in the right place to start typing — he had to click a second time before keystrokes registered.

The root cause was in Terminal.tsx:

• The wrapper <Box> used onClick to call terminalManager.focus(). React's synthetic click fires after the browser's native focus handling on mousedown/mouseup, so when the click landed on the padding (or anywhere outside the xterm canvas), focus had already shifted off the xterm helper textarea by the time we tried to put it back.
• Switching tabs also remounts the Terminal, but attach() never called term.focus(), so the terminal panel never auto-focused on appear.

Changes

• apps/code/src/renderer/features/terminal/components/Terminal.tsx
  • Swap onClick → onMouseDown so focus is set before the browser's native focus shift, not after.
  • Call terminalManager.focus(sessionId) right after attach() so opening/switching to a terminal tab focuses the xterm immediately.
• apps/code/src/renderer/features/sessions/components/SessionView.tsx
  • Removed a duplicate const { isOnline } = useConnectivity() declaration that was blocking the pre-commit typecheck (introduced by fix(sessions): preserve prompt when sending while offline #1971).

Test plan

• Open a task with a terminal panel — typing works without any click.
• Switch away from and back to the terminal tab — typing works without any click.
• Click on the padding around the xterm — first keystroke goes into the terminal.
• Click directly on the xterm canvas — still focuses (mousedown-driven, idempotent).
• Drag-select text in the terminal — selection still works (we don't preventDefault).

---

Created with PostHog Code

[greptile-apps]

_{Reviews (1): Last reviewed commit: "Merge branch 'main' into posthog-code/fi..." | Re-trigger Greptile}