Skip to content

feat(code): move suggested tasks to chips#2198

Merged
adboio merged 5 commits into
mainfrom
05-18-feat_code_move_suggested_tasks_to_chips
May 20, 2026
Merged

feat(code): move suggested tasks to chips#2198
adboio merged 5 commits into
mainfrom
05-18-feat_code_move_suggested_tasks_to_chips

Conversation

@adboio
Copy link
Copy Markdown
Contributor

@adboio adboio commented May 18, 2026

Problem

onboarding is getting revamped, we want to dump users directly on the new task page, which means suggested tasks need a new home

Changes

Screenshot 2026-05-19 at 5.55.47 PM.png Screenshot 2026-05-19 at 5.57.17 PM.png Screenshot 2026-05-19 at 5.57.19 PM.png

moves suggested tasks to chips below the input bar

capped at 4, with a "show more" that reveals the rest inline

chips go away when they are clicked

i think once everyone has inbox access, we should have the "show more" redirect to inbox probably

How did you test this?

manually

Publish to changelog?

no

Copy link
Copy Markdown
Contributor Author

adboio commented May 18, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@adboio adboio marked this pull request as ready for review May 18, 2026 18:49
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 18, 2026

Reviews (1): Last reviewed commit: "feat(code): move suggested tasks to chip..." | Re-trigger Greptile

@adboio adboio force-pushed the 05-18-feat_code_move_suggested_tasks_to_chips branch from b07f838 to d1adadb Compare May 18, 2026 20:29
@adboio adboio requested a review from a team May 19, 2026 14:44
@adboio adboio marked this pull request as draft May 19, 2026 16:58
@adboio adboio force-pushed the 05-18-feat_code_move_suggested_tasks_to_chips branch from d1adadb to a6b33f4 Compare May 19, 2026 20:08
@adboio adboio force-pushed the 05-18-feat_code_move_suggested_tasks_to_chips branch from a6b33f4 to 7941286 Compare May 20, 2026 00:57
@adboio adboio marked this pull request as ready for review May 20, 2026 00:59
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 20, 2026

Prompt To Fix All With AI
Fix the following 2 code review issues. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 2
apps/code/src/renderer/features/task-detail/components/TaskInput.tsx:537-545
**Missing `SETUP_TASK_SELECTED` analytics on chip click**

The new `handleSelectSuggestion` handler never calls `track(ANALYTICS_EVENTS.SETUP_TASK_SELECTED, ...)`. The old `SetupView.handleSelectTask` tracked this event with `discovered_task_id`, `category`, `position`, and `total_discovered`. Now that `SetupView` is deleted, this is the only code path that creates a task from a discovered suggestion, so the event will silently stop firing even though its type still exists in the `EventPropertyMap`.

### Issue 2 of 2
apps/code/src/renderer/features/task-detail/hooks/useTaskCreation.ts:263-264
`editor.clear()` runs unconditionally inside the task-created callback, even when the task was submitted via `contentOverride` (a chip click). If the user had typed a draft in the editor and then clicked a chip, the suggestion creates a task from the chip's text and then silently discards the editor draft. Since `contentOverride` is in scope at the call site, it can be used as a guard.

```suggestion
          useTourStore.getState().completeTour(createFirstTaskTour.id);
          if (!contentOverride) editor.clear();
```

Reviews (2): Last reviewed commit: "feat(code): move suggested tasks to chip..." | Re-trigger Greptile

@adboio adboio merged commit fe16cf1 into main May 20, 2026
16 checks passed
Copy link
Copy Markdown
Contributor Author

adboio commented May 20, 2026

Merge activity

@adboio adboio deleted the 05-18-feat_code_move_suggested_tasks_to_chips branch May 20, 2026 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants