feat(code): move suggested tasks to chips#2198
Merged
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
|
Reviews (1): Last reviewed commit: "feat(code): move suggested tasks to chip..." | Re-trigger Greptile |
b07f838 to
d1adadb
Compare
d1adadb to
a6b33f4
Compare
a6b33f4 to
7941286
Compare
Contributor
Prompt To Fix All With AIFix the following 2 code review issues. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 2
apps/code/src/renderer/features/task-detail/components/TaskInput.tsx:537-545
**Missing `SETUP_TASK_SELECTED` analytics on chip click**
The new `handleSelectSuggestion` handler never calls `track(ANALYTICS_EVENTS.SETUP_TASK_SELECTED, ...)`. The old `SetupView.handleSelectTask` tracked this event with `discovered_task_id`, `category`, `position`, and `total_discovered`. Now that `SetupView` is deleted, this is the only code path that creates a task from a discovered suggestion, so the event will silently stop firing even though its type still exists in the `EventPropertyMap`.
### Issue 2 of 2
apps/code/src/renderer/features/task-detail/hooks/useTaskCreation.ts:263-264
`editor.clear()` runs unconditionally inside the task-created callback, even when the task was submitted via `contentOverride` (a chip click). If the user had typed a draft in the editor and then clicked a chip, the suggestion creates a task from the chip's text and then silently discards the editor draft. Since `contentOverride` is in scope at the call site, it can be used as a guard.
```suggestion
useTourStore.getState().completeTour(createFirstTaskTour.id);
if (!contentOverride) editor.clear();
```
Reviews (2): Last reviewed commit: "feat(code): move suggested tasks to chip..." | Re-trigger Greptile |
charlesvien
approved these changes
May 20, 2026
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem
onboarding is getting revamped, we want to dump users directly on the new task page, which means suggested tasks need a new home
Changes
moves suggested tasks to chips below the input bar
capped at 4, with a "show more" that reveals the rest inline
chips go away when they are clicked
i think once everyone has inbox access, we should have the "show more" redirect to inbox probably
How did you test this?
manually
Publish to changelog?
no