Skip to content

feat: Remove signals step to improve conversion#2208

Merged
charlesvien merged 1 commit into
mainfrom
05-18-remove_signals_step_to_improve_conversion
May 19, 2026
Merged

feat: Remove signals step to improve conversion#2208
charlesvien merged 1 commit into
mainfrom
05-18-remove_signals_step_to_improve_conversion

Conversation

@charlesvien
Copy link
Copy Markdown
Member

@charlesvien charlesvien commented May 19, 2026

Problem

The signals/inbox setup forces users to configure integrations during onboarding, hurting conversion. The inbox already shows a setup pane on first open, so this step is redundant.

Changes

  1. Drop signals from onboarding step union and array
  2. Make install-cli the final step; complete onboarding straight to task input
  3. Update install-cli CTA copy to "Get started" / "Skip & get started"
  4. Delete SignalsStep and usePrefetchSignalData (now orphaned)
  5. Remove navigateToSetup / hasCompletedSetup branching from OnboardingFlow

How did you test this?

Manually

Publish to changelog?

Copy link
Copy Markdown
Member Author

charlesvien commented May 19, 2026

@charlesvien charlesvien marked this pull request as ready for review May 19, 2026 01:14
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 19, 2026

Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
apps/code/src/renderer/features/onboarding/components/OnboardingFlow.tsx:46
**Lost prefetch for GitHub integration step**

`usePrefetchSignalData` was also eagerly prefetching `["integrations", projectId]`, `["integrations", "list"]`, and the nested GitHub repositories — data consumed by the still-present `GitIntegrationStep`. Removing the hook means those queries will now be fetched on-demand when the user arrives at the GitHub step, adding a visible loading delay that didn't exist before. Consider either keeping the integrations-only prefetch (renaming the hook to reflect its scope) or adding an equivalent prefetch inside `GitIntegrationStep` itself.

Reviews (1): Last reviewed commit: "Remove signals step to improve conversio..." | Re-trigger Greptile

(state) => state.navigateToTaskInput,
);
const logoutMutation = useLogoutMutation();
const isAuthenticated = useAuthStateValue(
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Lost prefetch for GitHub integration step

usePrefetchSignalData was also eagerly prefetching ["integrations", projectId], ["integrations", "list"], and the nested GitHub repositories — data consumed by the still-present GitIntegrationStep. Removing the hook means those queries will now be fetched on-demand when the user arrives at the GitHub step, adding a visible loading delay that didn't exist before. Consider either keeping the integrations-only prefetch (renaming the hook to reflect its scope) or adding an equivalent prefetch inside GitIntegrationStep itself.

Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/code/src/renderer/features/onboarding/components/OnboardingFlow.tsx
Line: 46

Comment:
**Lost prefetch for GitHub integration step**

`usePrefetchSignalData` was also eagerly prefetching `["integrations", projectId]`, `["integrations", "list"]`, and the nested GitHub repositories — data consumed by the still-present `GitIntegrationStep`. Removing the hook means those queries will now be fetched on-demand when the user arrives at the GitHub step, adding a visible loading delay that didn't exist before. Consider either keeping the integrations-only prefetch (renaming the hook to reflect its scope) or adding an equivalent prefetch inside `GitIntegrationStep` itself.

How can I resolve this? If you propose a fix, please make it concise.

@charlesvien charlesvien changed the title Remove signals step to improve conversion feat: Remove signals step to improve conversion May 19, 2026
@charlesvien charlesvien changed the base branch from main to graphite-base/2208 May 19, 2026 06:05
@charlesvien charlesvien force-pushed the 05-18-remove_signals_step_to_improve_conversion branch from 061d724 to e7fd357 Compare May 19, 2026 06:05
@charlesvien charlesvien changed the base branch from graphite-base/2208 to 05-17-misc_fixes May 19, 2026 06:06
@charlesvien charlesvien mentioned this pull request May 19, 2026
@jonathanlab jonathanlab changed the base branch from 05-17-misc_fixes to graphite-base/2208 May 19, 2026 13:41
@jonathanlab jonathanlab force-pushed the graphite-base/2208 branch from 1b824ae to 469d6fb Compare May 19, 2026 13:41
@jonathanlab jonathanlab force-pushed the 05-18-remove_signals_step_to_improve_conversion branch from e7fd357 to fcde1a8 Compare May 19, 2026 13:41
@graphite-app graphite-app Bot changed the base branch from graphite-base/2208 to main May 19, 2026 13:42
@jonathanlab jonathanlab force-pushed the 05-18-remove_signals_step_to_improve_conversion branch from fcde1a8 to 8d57b36 Compare May 19, 2026 13:42
@charlesvien charlesvien force-pushed the 05-18-remove_signals_step_to_improve_conversion branch from 8d57b36 to 02e2814 Compare May 19, 2026 16:08
@charlesvien charlesvien force-pushed the 05-18-remove_signals_step_to_improve_conversion branch from 02e2814 to bbf8999 Compare May 19, 2026 20:37
@charlesvien charlesvien merged commit 65c80c0 into main May 19, 2026
16 checks passed
@charlesvien charlesvien deleted the 05-18-remove_signals_step_to_improve_conversion branch May 19, 2026 22:09
Twixes added a commit that referenced this pull request May 26, 2026
PR #2208 dropped the signals step from app onboarding to improve conversion, but the setup UX it removed never landed anywhere else — users with no GitHub or no signal sources just saw a stripped-down WelcomePane that bounced them into a modal.

Replaces that empty state with an inline InboxSetupPane that mirrors the deleted SignalsStep (hero copy, detective hog tip, animated entrance) and embeds SignalSourcesSettings so users get GitHub connect, source toggles, PR auto-start threshold, and Slack notifications without leaving the Inbox. Warming-up state and the configuration dialog (still opened from the toolbar and auto-open effect) are unchanged.

Generated-By: PostHog Code
Task-Id: 3f6eaf93-f574-44d9-aa91-bc4a7b8a68b9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants