-
Notifications
You must be signed in to change notification settings - Fork 30
feat(code): add Discuss button to inbox reports #2241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
364732c
feat(code): add Discuss button to inbox reports
andrewm4894 4e3468a
fix(code): align discuss tooltip styling
andrewm4894 5a612cc
fix(code): allow inbox discuss auto-submit while loading
andrewm4894 5a8bb2b
fix(code): apply discuss mode override before autosubmit
andrewm4894 6853ee9
feat(code): add discuss prompt popover
andrewm4894 d526438
fix(code): clear autosubmitted task prompt draft
andrewm4894 c075c7c
fix(code): preserve discuss auto mode
andrewm4894 3f9a191
fix(code): use discuss execution mode for autosubmit
andrewm4894 9c3dec0
Merge remote-tracking branch 'origin/main' into inbox-discuss-button
andrewm4894 3b4a866
fix(inbox): instrument Discuss action and unblock markdown test
andrewm4894 46e0015
feat(inbox): capture Discuss question text in analytics
andrewm4894 75662a8
refactor(deeplink): hoist isPostHogCodeDeeplink to shared/deeplink
andrewm4894 32fe704
refactor(inbox): extract Discuss prompt construction to a builder
andrewm4894 9615f39
refactor(inbox): create Discuss tasks directly without TaskInput
andrewm4894 cfe9107
refactor(markdown): drop inline trpc import, mock client in UserMessa…
andrewm4894 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any way we can avoid this inline import pattern?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in cfe9107. Inline import is gone — back to a top-level
import { trpcClient }like every other call site.The reason it was lazy in the first place was that
UserMessage.test.tsxwas failing at module init becausetrpc/client.tscallsipcLink()which needswindow.electronTRPC, andMarkdownRendererwas the first thing inUserMessage's import graph to reach it. Fixed properly by addingvi.mock("@renderer/trpc/client", ...)to the test — same pattern 14 other test files already use.