fix(code): give plan approval more room and a discoverable expand button#2263
Draft
posthog[bot] wants to merge 1 commit into
Draft
fix(code): give plan approval more room and a discoverable expand button#2263posthog[bot] wants to merge 1 commit into
posthog[bot] wants to merge 1 commit into
Conversation
Plans previously rendered inside a 50vh × 750px scroll box with a 12px floating fullscreen icon. Add a labeled header row with a "Plan" title and an "Expand" button, bump the inline max-height to 75vh, and replace the bare ArrowsIn placeholder shown when fullscreen is active with an explicit "Plan opened in fullscreen / Exit fullscreen" affordance so the return path is always obvious. Generated-By: PostHog Code Task-Id: 21dcadb5-cfe8-45a1-a613-bd79be9afae8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Users in plan mode were complaining that implementation plans show up in a cramped scroll box that feels read-only. The plan markdown is rendered inside a fixed
max-h-[50vh] max-w-[750px]box inPlanContent.tsx, and the fullscreen escape hatch is a 12px ghostArrowsOutIconButton floated in the top-right corner — easy to miss. Once a long plan is rendered, most of it is hidden behind a small scrollbar and there's no obvious way to expand.Refs #1492
Changes
In
apps/code/src/renderer/components/permissions/PlanContent.tsx:ListChecksicon, a "Plan" title, and a clearly-labeledExpandbutton (icon + text, RadixButtonghost) instead of the 12px floating IconButton.max-h-[50vh]tomax-h-[75vh]so plans get noticeably more vertical room before scrolling kicks in.ArrowsInplaceholder that gets rendered inline while the fullscreen overlay is open with an explicitPlan opened in fullscreen / Exit fullscreenaffordance — so users always know where the plan went and how to come back.No changes to
PlanApprovalView.tsx— the wrapper still passes the same props through.How did you test this?
pnpm --filter code typecheck✅pnpm exec biome check apps/code/src/renderer/components/permissions/PlanContent.tsx✅pnpm build(turbo) ✅Publish to changelog?
no
Created with PostHog Code