fix(analytics): resolve INBOX_VIEWED typecheck errors#2286
Merged
Conversation
INBOX_VIEWED was declared twice in ANALYTICS_EVENTS and twice in the event-properties map (once as never, once as InboxViewedProperties), producing TS1117/TS2717 and failing the repo-wide typecheck on every PR. Keep the properties-bearing definition (InboxSignalsTab fires INBOX_VIEWED with real data) and drop the duplicates, then remove the redundant no-argument track(INBOX_VIEWED) in navigationStore.navigateToInbox that is now type-incorrect and re-fired the event without properties.
andrewm4894
approved these changes
May 21, 2026
Contributor
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
apps/code/src/renderer/stores/navigationStore.ts:259-261
**Analytics gap for scale-gated inbox users**
After this change, `INBOX_VIEWED` is only fired from `InboxSignalsTab`, which is not rendered when `isGatedDueToScale` is true — `InboxView` renders `GatedDueToScalePane` instead. Users hitting that path will no longer produce any `INBOX_VIEWED` event. Before this PR the property-less `track` call in `navigateToInbox` covered that case (even if it lacked properties). If measuring how often gated users reach the inbox is important, a tracking call (with appropriate properties) should be added to `GatedDueToScalePane` or left in `navigateToInbox` with the correct `InboxViewedProperties`.
Reviews (1): Last reviewed commit: "fix(analytics): resolve INBOX_VIEWED typ..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Removing the navigateToInbox track call left scale-gated users (who see GatedDueToScalePane instead of InboxSignalsTab) without any INBOX_VIEWED event. Fire it from InboxView on the gated path, marked with a new is_gated_due_to_scale property so gated visits are distinguishable from a genuinely empty inbox.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
typecheckjob fails on every PR:INBOX_VIEWEDis declared twice inANALYTICS_EVENTSand twice in the event-properties map