-
Notifications
You must be signed in to change notification settings - Fork 30
feat(agent): route signal_report tasks to signals gateway product #2288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
joshsny
merged 4 commits into
main
from
posthog-code/route-signal-report-tasks-to-signals
May 21, 2026
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
f318ff1
feat(agent): route signal_report tasks to signals gateway product
joshsny 145dcfc
feat(agent): forward task_origin_product and task_internal to gateway
joshsny 4f14949
feat(agent): forward task_id, task_run_id, and task_user_id to gateway
joshsny b43925a
test(agent): parameterise resolveGatewayProduct cases with it.each
joshsny File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| import { describe, expect, it } from "vitest"; | ||
| import { buildGatewayPropertyHeaders, resolveGatewayProduct } from "./gateway"; | ||
|
|
||
| describe("resolveGatewayProduct", () => { | ||
| it.each([ | ||
| { isInternal: false, originProduct: undefined, expected: "posthog_code" }, | ||
| { | ||
| isInternal: undefined, | ||
| originProduct: undefined, | ||
| expected: "posthog_code", | ||
| }, | ||
| { | ||
| isInternal: false, | ||
| originProduct: "signal_report", | ||
| expected: "posthog_code", | ||
| }, | ||
| { | ||
| isInternal: true, | ||
| originProduct: undefined, | ||
| expected: "background_agents", | ||
| }, | ||
| { | ||
| isInternal: true, | ||
| originProduct: "session_summaries", | ||
| expected: "background_agents", | ||
| }, | ||
| { isInternal: true, originProduct: "signal_report", expected: "signals" }, | ||
| ] as const)( | ||
| "isInternal=$isInternal originProduct=$originProduct -> $expected", | ||
| ({ isInternal, originProduct, expected }) => { | ||
| expect(resolveGatewayProduct({ isInternal, originProduct })).toBe( | ||
| expected, | ||
| ); | ||
| }, | ||
| ); | ||
| }); | ||
|
|
||
| describe("buildGatewayPropertyHeaders", () => { | ||
| it("renders each property as an x-posthog-property header line", () => { | ||
| expect( | ||
| buildGatewayPropertyHeaders({ | ||
| task_origin_product: "signal_report", | ||
| task_internal: true, | ||
| }), | ||
| ).toBe( | ||
| "x-posthog-property-task_origin_product: signal_report\nx-posthog-property-task_internal: true", | ||
| ); | ||
| }); | ||
|
|
||
| it("drops null and undefined values but keeps falsy primitives", () => { | ||
| expect( | ||
| buildGatewayPropertyHeaders({ | ||
| task_origin_product: null, | ||
| task_internal: false, | ||
| task_count: 0, | ||
| }), | ||
| ).toBe( | ||
| "x-posthog-property-task_internal: false\nx-posthog-property-task_count: 0", | ||
| ); | ||
| }); | ||
|
|
||
| it("returns an empty string when no usable properties remain", () => { | ||
| expect( | ||
| buildGatewayPropertyHeaders({ | ||
| task_origin_product: null, | ||
| task_internal: undefined, | ||
| }), | ||
| ).toBe(""); | ||
| }); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.