fix(task-input): stop composer flicker on long multi-line prompts#2291
Closed
fercgomes wants to merge 4 commits into
Closed
fix(task-input): stop composer flicker on long multi-line prompts#2291fercgomes wants to merge 4 commits into
fercgomes wants to merge 4 commits into
Conversation
The "New task" composer column was wrapped in a framer-motion `<motion.div layout>` with a 250ms transition. Each line added to the Tiptap editor triggered a layout animation; rapid keystrokes interrupted each other, producing a visible one-line up/down oscillation as the prompt grew past a few lines. Replace the wrapper with a plain `<div>` so the editor's natural growth is instantaneous. The suggestions panel below still animates entry/exit through its own `AnimatePresence`. Generated-By: PostHog Code Task-Id: 2184b3af-160d-4a75-bd82-199fecf70f41
Contributor
|
Reviews (1): Last reviewed commit: "fix(task-input): stop composer flicker o..." | Re-trigger Greptile |
…oser-flicker # Conflicts: # apps/code/src/renderer/features/task-detail/components/TaskInput.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The "New task" composer flickered — bouncing up and down by one line — when typing a long, multi-line prompt. The column was wrapped in a framer-motion
<motion.div layout>with a 250ms transition, so each new Tiptap line triggered a layout animation; rapid keystrokes interrupted each other and produced a visible one-line oscillation.<LayoutGroup>+<motion.div layout>wrapper with a plain<div>so the editor grows instantaneously.framer-motionimport.AnimatePresence, so no animation is lost.Screen.Recording.2026-05-21.at.16.21.31.mov
Test plan
pnpm dev:code, open New task, type a prompt long enough to wrap to ~5 lines — composer grows smoothly with no flicker.max-h-[45vh]— inner scroll engages cleanly.SuggestedTasksPanelshows entries below the editor, then type — suggestions don't flicker and don't push the editor around.