Group MCP tools by capability#2293
Open
GChaucer wants to merge 2 commits into
Open
Conversation
Contributor
Prompt To Fix All With AIFix the following 2 code review issues. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 2
apps/code/src/renderer/features/mcp-servers/hooks/mcpToolGroups.test.ts:25-37
**Prefer parameterised tests**
The first two `it` blocks each assert multiple cases as individual `expect` calls. When one assertion fails, the rest are skipped, hiding further failures. Prefer `it.each` so each case is its own named test. The same pattern applies to the write/delete block below.
### Issue 2 of 2
apps/code/src/renderer/features/mcp-servers/components/parts/ServerDetailView.tsx:433-456
**OnceAndOnlyOnce: duplicate handler**
The identical `onToolApprovalChange` callback is defined twice — once for each `ToolGroupSection`. Extract it to a `useCallback` (or a plain `const` before the return) so both sections share a single definition.
```suggestion
) : (
<>
<ToolGroupSection
title="Read tools"
tools={groupedTools.read}
onToolApprovalChange={(toolName, approval_state) =>
setToolApproval({ toolName, approval_state })
}
/>
<ToolGroupSection
title="Write / delete tools"
tools={groupedTools.write_delete}
onToolApprovalChange={(toolName, approval_state) =>
setToolApproval({ toolName, approval_state })
}
/>
</>
)}
```
Reviews (1): Last reviewed commit: "Group MCP tools by capability" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+25
to
+37
| it("classifies clear read verbs from tool names", () => { | ||
| expect(getMcpToolGroup(tool("get_ticket"))).toBe("read"); | ||
| expect(getMcpToolGroup(tool("list_projects"))).toBe("read"); | ||
| expect(getMcpToolGroup(tool("search_docs"))).toBe("read"); | ||
| expect(getMcpToolGroup(tool("lookup_customer"))).toBe("read"); | ||
| }); | ||
|
|
||
| it("classifies clear write and delete verbs from tool names", () => { | ||
| expect(getMcpToolGroup(tool("create_ticket"))).toBe("write_delete"); | ||
| expect(getMcpToolGroup(tool("delete_file"))).toBe("write_delete"); | ||
| expect(getMcpToolGroup(tool("send_message"))).toBe("write_delete"); | ||
| expect(getMcpToolGroup(tool("run_query"))).toBe("write_delete"); | ||
| }); |
Contributor
There was a problem hiding this comment.
The first two it blocks each assert multiple cases as individual expect calls. When one assertion fails, the rest are skipped, hiding further failures. Prefer it.each so each case is its own named test. The same pattern applies to the write/delete block below.
Context Used: Do not attempt to comment on incorrect alphabetica... (source)
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/code/src/renderer/features/mcp-servers/hooks/mcpToolGroups.test.ts
Line: 25-37
Comment:
**Prefer parameterised tests**
The first two `it` blocks each assert multiple cases as individual `expect` calls. When one assertion fails, the rest are skipped, hiding further failures. Prefer `it.each` so each case is its own named test. The same pattern applies to the write/delete block below.
**Context Used:** Do not attempt to comment on incorrect alphabetica... ([source](https://app.greptile.com/review/custom-context?memory=instruction-0))
How can I resolve this? If you propose a fix, please make it concise.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Comment on lines
433
to
456
| ) : ( | ||
| filteredTools.map((tool) => ( | ||
| <ToolRow | ||
| key={tool.tool_name} | ||
| tool={tool} | ||
| onChange={(approval_state) => | ||
| <> | ||
| <ToolGroupSection | ||
| title="Read tools" | ||
| tools={groupedTools.read} | ||
| onToolApprovalChange={(toolName, approval_state) => | ||
| setToolApproval({ | ||
| toolName: tool.tool_name, | ||
| toolName, | ||
| approval_state, | ||
| }) | ||
| } | ||
| /> | ||
| )) | ||
| <ToolGroupSection | ||
| title="Write / delete tools" | ||
| tools={groupedTools.write_delete} | ||
| onToolApprovalChange={(toolName, approval_state) => | ||
| setToolApproval({ | ||
| toolName, | ||
| approval_state, | ||
| }) | ||
| } | ||
| /> | ||
| </> | ||
| )} |
Contributor
There was a problem hiding this comment.
The identical onToolApprovalChange callback is defined twice — once for each ToolGroupSection. Extract it to a useCallback (or a plain const before the return) so both sections share a single definition.
Suggested change
| ) : ( | |
| filteredTools.map((tool) => ( | |
| <ToolRow | |
| key={tool.tool_name} | |
| tool={tool} | |
| onChange={(approval_state) => | |
| <> | |
| <ToolGroupSection | |
| title="Read tools" | |
| tools={groupedTools.read} | |
| onToolApprovalChange={(toolName, approval_state) => | |
| setToolApproval({ | |
| toolName: tool.tool_name, | |
| toolName, | |
| approval_state, | |
| }) | |
| } | |
| /> | |
| )) | |
| <ToolGroupSection | |
| title="Write / delete tools" | |
| tools={groupedTools.write_delete} | |
| onToolApprovalChange={(toolName, approval_state) => | |
| setToolApproval({ | |
| toolName, | |
| approval_state, | |
| }) | |
| } | |
| /> | |
| </> | |
| )} | |
| ) : ( | |
| <> | |
| <ToolGroupSection | |
| title="Read tools" | |
| tools={groupedTools.read} | |
| onToolApprovalChange={(toolName, approval_state) => | |
| setToolApproval({ toolName, approval_state }) | |
| } | |
| /> | |
| <ToolGroupSection | |
| title="Write / delete tools" | |
| tools={groupedTools.write_delete} | |
| onToolApprovalChange={(toolName, approval_state) => | |
| setToolApproval({ toolName, approval_state }) | |
| } | |
| /> | |
| </> | |
| )} |
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/code/src/renderer/features/mcp-servers/components/parts/ServerDetailView.tsx
Line: 433-456
Comment:
**OnceAndOnlyOnce: duplicate handler**
The identical `onToolApprovalChange` callback is defined twice — once for each `ToolGroupSection`. Extract it to a `useCallback` (or a plain `const` before the return) so both sections share a single definition.
```suggestion
) : (
<>
<ToolGroupSection
title="Read tools"
tools={groupedTools.read}
onToolApprovalChange={(toolName, approval_state) =>
setToolApproval({ toolName, approval_state })
}
/>
<ToolGroupSection
title="Write / delete tools"
tools={groupedTools.write_delete}
onToolApprovalChange={(toolName, approval_state) =>
setToolApproval({ toolName, approval_state })
}
/>
</>
)}
```
How can I resolve this? If you propose a fix, please make it concise.
jonathanlab
requested changes
May 22, 2026
Contributor
There was a problem hiding this comment.
This is IMO the wrong way of going about it. MCP tools expose whether they actually are read only, destructive, etc. via tool annotations. We should use that instead: https://modelcontextprotocol.io/specification/2025-11-25/schema#toolannotations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Read toolsandWrite / delete toolssections.Write / delete toolsfor safer review.Closes #2233
Testing
corepack pnpm --dir apps/code exec vitest run src/renderer/features/mcp-servers/hooks/mcpToolGroups.test.tscorepack pnpm --dir apps/code typecheckcorepack pnpm exec biome check apps/code/src/renderer/features/mcp-servers/hooks/mcpToolGroups.ts apps/code/src/renderer/features/mcp-servers/hooks/mcpToolGroups.test.ts apps/code/src/renderer/features/mcp-servers/components/parts/ServerDetailView.tsxgit diff --checkNotes