Skip to content

fix(cloud): signing mcp cloud only#2300

Merged
tatoalo merged 2 commits into
mainfrom
fix/cloud-agent/signing-mcp-cloud-only
May 22, 2026
Merged

fix(cloud): signing mcp cloud only#2300
tatoalo merged 2 commits into
mainfrom
fix/cloud-agent/signing-mcp-cloud-only

Conversation

@tatoalo
Copy link
Copy Markdown
Contributor

@tatoalo tatoalo commented May 22, 2026

Problem

local signing MCP tool must be only tied to cloud runs. it wasn't. now it is.

@tatoalo tatoalo self-assigned this May 22, 2026
@tatoalo tatoalo requested a review from a team May 22, 2026 15:58
@tatoalo tatoalo added the Create Release This will trigger a new release label May 22, 2026
@tatoalo tatoalo requested a review from pauldambra May 22, 2026 16:00
@tatoalo tatoalo enabled auto-merge (squash) May 22, 2026 16:00
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 22, 2026

Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
packages/agent/src/adapters/local-tools/registry.ts:20-24
`taskRunId` is no longer used in any tool gate — `isCloudRun` was the only consumer and it now reads `environment` instead. Keeping the field in `LocalToolGateMeta` contradicts the "minimal shape needed to gate tools" doc comment and the simplicity rule of no superfluous parts. Removing it makes the contract clear: only `environment` signals cloud/local for gating purposes.

```suggestion
/** Minimal session-meta shape needed to gate tools (e.g. cloud-only). */
export interface LocalToolGateMeta {
  environment?: "local" | "cloud";
}
```

Reviews (1): Last reviewed commit: "fix(cloud): signing mcp cloud only" | Re-trigger Greptile

Comment thread packages/agent/src/adapters/local-tools/registry.ts
Copy link
Copy Markdown
Member

@Piccirello Piccirello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very low context stamp

@tatoalo tatoalo merged commit 7207e22 into main May 22, 2026
15 checks passed
@tatoalo tatoalo deleted the fix/cloud-agent/signing-mcp-cloud-only branch May 22, 2026 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Create Release This will trigger a new release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants