fix(cloud): signing mcp cloud only#2300
Merged
Merged
Conversation
Contributor
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
packages/agent/src/adapters/local-tools/registry.ts:20-24
`taskRunId` is no longer used in any tool gate — `isCloudRun` was the only consumer and it now reads `environment` instead. Keeping the field in `LocalToolGateMeta` contradicts the "minimal shape needed to gate tools" doc comment and the simplicity rule of no superfluous parts. Removing it makes the contract clear: only `environment` signals cloud/local for gating purposes.
```suggestion
/** Minimal session-meta shape needed to gate tools (e.g. cloud-only). */
export interface LocalToolGateMeta {
environment?: "local" | "cloud";
}
```
Reviews (1): Last reviewed commit: "fix(cloud): signing mcp cloud only" | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
local signing MCP tool must be only tied to cloud runs. it wasn't. now it is.