fix(ci): repair mobile build/promote workflows#2301
Open
Gilbert09 wants to merge 3 commits into
Open
Conversation
The promote job set permissions:{} (contents:none) but the called
mobile-promote.yml submit job requests contents:read, which GitHub
rejects as an invalid workflow file.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The previous SHA did not exist in expo/expo-github-action, breaking both mobile-build and mobile-promote. Pin to the real v8 commit. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
eas submit --non-interactive cannot resolve the App Store Connect app without ascAppId. Pin it so iOS promotion works in CI. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
Reviews (1): Last reviewed commit: "fix(mobile): set ascAppId for iOS submit..." | Re-trigger Greptile |
Gilbert09
added
the
Stamphog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
Mobile Buildworkflow failed to even parse, and the promote/submit path had several misconfigurations. This PR fixes the chain end-to-end:promotejob inmobile-build.ymlsetpermissions: {}(contents: none), but the reusablemobile-promote.ymlsubmitjob requestscontents: read. GitHub rejects a caller granting less than the callee needs, producing an "Invalid workflow file" error. Bumped the job tocontents: read.expo/expo-github-actionwas pinned to a SHA that doesn't exist in the repo (Unable to resolve action ... unable to find version). Repinned to the realv8commit in bothmobile-build.ymlandmobile-promote.yml.eas submit --non-interactivefailed with "Set ascAppId in the submit profile". AddedascAppIdtosubmit.production.iosineas.json.(Android Play Store submission credentials were sorted separately on EAS.)
Testing
Dispatched
mobile-build.yml(profile=production, wait=true) against this branch:Setup EASresolves the action on both iOS and Android🤖 Generated with Claude Code