Skip to content

Simplify cloud environment dropdown when only one environment exists #2304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
joshsny wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Simplify cloud environment dropdown when only one environment exists #2304

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 31 additions & 11 deletions apps/code/src/renderer/features/task-detail/components/WorkspaceModeSelect.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,21 +163,41 @@ export function WorkspaceModeSelect({
))}
</DropdownMenuGroup>

{showCloud && (
{showCloud && environments.length === 0 && (
<DropdownMenuItem
onClick={() => {
onChange("cloud");
onCloudEnvironmentChange?.(null);
}}
render={
<ItemMenuItem size="xs" className="w-full">
<ItemMedia variant="icon" className="mt-2 ml-2">
<span>{CLOUD_ICON}</span>
</ItemMedia>
<ItemContent variant="menuItem">
<ItemTitle>Cloud</ItemTitle>
<ItemDescription className="whitespace-nowrap leading-none">
Run in a cloud sandbox
</ItemDescription>
</ItemContent>
</ItemMenuItem>
}
/>
)}

{showCloud && environments.length > 0 && (
<>
<DropdownMenuSeparator />
<div className="flex items-center justify-between px-2 py-1">
<MenuLabel className="p-0">Cloud environments</MenuLabel>
{environments.length > 0 && (
<button
type="button"
onClick={handleAddEnvironment}
aria-label="Add cloud environment"
className="flex cursor-pointer items-center justify-center rounded-sm border-0 bg-transparent p-0.5 text-muted-foreground transition-colors hover:bg-fill-hover hover:text-foreground"
>
<Plus size={12} />
</button>
)}
<button
type="button"
onClick={handleAddEnvironment}
aria-label="Add cloud environment"
className="flex cursor-pointer items-center justify-center rounded-sm border-0 bg-transparent p-0.5 text-muted-foreground transition-colors hover:bg-fill-hover hover:text-foreground"
>
<Plus size={12} />
</button>
</div>

<DropdownMenuGroup>
Expand Down
Loading