fix(inbox): re-seat keyboard cursor on click

[oliverb123]

Summary

• Arrow-key navigation in the inbox kept a local keyboardCursorIdRef that was only written by the keyboard handler. After a click, the ref still pointed at the previous keyboard position, so the next arrow press navigated from there instead of from the just-clicked report.
• Extracted the navigation into useInboxKeyboardNavigation, which subscribes to lastClickedId in the selection store and re-seats the cursor on every click. Shift+Arrow still walks the cursor independently (it deliberately doesn't touch lastClickedId, which stays the anchor for range extension).
• 16 regression tests, including the exact scenario from the bug thread. Verified they fail (10/16) when the sync effect is removed.

Test plan

• pnpm exec vitest run src/renderer/features/inbox/ — 81/81 pass
• pnpm --filter code typecheck
• pnpm exec biome check on changed files
• Manual smoke: click a report, arrow-key, confirm neighbour is selected
• Shift+Arrow extends a range and Shift+ArrowUp contracts it

[greptile-apps]

Prompt To Fix All With AI

Fix the following 2 code review issues. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 2
apps/code/src/renderer/features/inbox/hooks/useInboxKeyboardNavigation.test.tsx:64-86
The two "empty selection" tests exercise the same body with `1` and `-1`; prefer `it.each` per the team's parameterised-tests rule.

```suggestion
    it.each<[1 | -1, string]>([
      [1, "ArrowDown"],
      [-1, "ArrowUp"],
    ])("%s selects the first report when nothing is selected", (direction) => {
      const { result } = renderHook(() =>
        useInboxKeyboardNavigation({ reports: REPORTS }),
      );

      act(() => {
        result.current.navigateReport(direction, false);
      });

      expect(getSelection()).toEqual(["a"]);
    });
```

### Issue 2 of 2
apps/code/src/renderer/features/inbox/hooks/useInboxKeyboardNavigation.test.tsx:219-245
Same pattern in the bounds block — `ArrowDown at last` and `ArrowUp at first` are mirror images that collapse naturally into a single `it.each`.

```suggestion
    it.each<[1 | -1, string]>([
      [1, "e"],
      [-1, "a"],
    ])("direction %i at the boundary stays on the same report", (direction, reportId) => {
      const { result } = renderHook(() =>
        useInboxKeyboardNavigation({ reports: REPORTS }),
      );

      plainClick(reportId);

      act(() => {
        result.current.navigateReport(direction, false);
      });

      expect(getSelection()).toEqual([reportId]);
    });
```

_{Reviews (1): Last reviewed commit: "fix(inbox): re-seat keyboard cursor on c..." | Re-trigger Greptile}

[greptile-apps]

The two "empty selection" tests exercise the same body with 1 and -1; prefer it.each per the team's parameterised-tests rule.

Suggested change

	it("ArrowDown selects the first report", () => {
	const { result } = renderHook(() =>
	useInboxKeyboardNavigation({ reports: REPORTS }),
	);
	act(() => {
	result.current.navigateReport(1, false);
	});
	expect(getSelection()).toEqual(["a"]);
	});
	it("ArrowUp also selects the first report when nothing is selected", () => {
	const { result } = renderHook(() =>
	useInboxKeyboardNavigation({ reports: REPORTS }),
	);
	act(() => {
	result.current.navigateReport(-1, false);
	});
	expect(getSelection()).toEqual(["a"]);
	});
	it.each<[1 | -1, string]>([
	[1, "ArrowDown"],
	[-1, "ArrowUp"],
	])("%s selects the first report when nothing is selected", (direction) => {
	const { result } = renderHook(() =>
	useInboxKeyboardNavigation({ reports: REPORTS }),
	);
	act(() => {
	result.current.navigateReport(direction, false);
	});
	expect(getSelection()).toEqual(["a"]);
	});

Context Used: Do not attempt to comment on incorrect alphabetica... (source)

Prompt To Fix With AI

This is a comment left during a code review.
Path: apps/code/src/renderer/features/inbox/hooks/useInboxKeyboardNavigation.test.tsx
Line: 64-86

Comment:
The two "empty selection" tests exercise the same body with `1` and `-1`; prefer `it.each` per the team's parameterised-tests rule.

```suggestion
    it.each<[1 | -1, string]>([
      [1, "ArrowDown"],
      [-1, "ArrowUp"],
    ])("%s selects the first report when nothing is selected", (direction) => {
      const { result } = renderHook(() =>
        useInboxKeyboardNavigation({ reports: REPORTS }),
      );

      act(() => {
        result.current.navigateReport(direction, false);
      });

      expect(getSelection()).toEqual(["a"]);
    });
```

**Context Used:** Do not attempt to comment on incorrect alphabetica... ([source](https://app.greptile.com/review/custom-context?memory=instruction-0))

How can I resolve this? If you propose a fix, please make it concise.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

[greptile-apps]

Same pattern in the bounds block — ArrowDown at last and ArrowUp at first are mirror images that collapse naturally into a single it.each.

Suggested change

	it("ArrowDown on the last report stays on the last report", () => {
	const { result } = renderHook(() =>
	useInboxKeyboardNavigation({ reports: REPORTS }),
	);
	plainClick("e");
	act(() => {
	result.current.navigateReport(1, false);
	});
	expect(getSelection()).toEqual(["e"]);
	});
	it("ArrowUp on the first report stays on the first report", () => {
	const { result } = renderHook(() =>
	useInboxKeyboardNavigation({ reports: REPORTS }),
	);
	plainClick("a");
	act(() => {
	result.current.navigateReport(-1, false);
	});
	expect(getSelection()).toEqual(["a"]);
	});
	it.each<[1 | -1, string]>([
	[1, "e"],
	[-1, "a"],
	])("direction %i at the boundary stays on the same report", (direction, reportId) => {
	const { result } = renderHook(() =>
	useInboxKeyboardNavigation({ reports: REPORTS }),
	);
	plainClick(reportId);
	act(() => {
	result.current.navigateReport(direction, false);
	});
	expect(getSelection()).toEqual([reportId]);
	});

Context Used: Do not attempt to comment on incorrect alphabetica... (source)

Prompt To Fix With AI

This is a comment left during a code review.
Path: apps/code/src/renderer/features/inbox/hooks/useInboxKeyboardNavigation.test.tsx
Line: 219-245

Comment:
Same pattern in the bounds block — `ArrowDown at last` and `ArrowUp at first` are mirror images that collapse naturally into a single `it.each`.

```suggestion
    it.each<[1 | -1, string]>([
      [1, "e"],
      [-1, "a"],
    ])("direction %i at the boundary stays on the same report", (direction, reportId) => {
      const { result } = renderHook(() =>
        useInboxKeyboardNavigation({ reports: REPORTS }),
      );

      plainClick(reportId);

      act(() => {
        result.current.navigateReport(direction, false);
      });

      expect(getSelection()).toEqual([reportId]);
    });
```

**Context Used:** Do not attempt to comment on incorrect alphabetica... ([source](https://app.greptile.com/review/custom-context?memory=instruction-0))

How can I resolve this? If you propose a fix, please make it concise.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!