chore(devex): Added stamphog to code#2316
Open
Gilbert09 wants to merge 3 commits into
Open
Conversation
Contributor
Prompt To Fix All With AIFix the following 2 code review issues. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 2
.github/workflows/pr-approval-agent.yml:68-71
**Missing Python scripts — workflow dead on arrival**
`tools/pr-approval-agent/review_pr.py` does not exist anywhere in this repository (verified against both the PR head and the `master` branch). The workflow always checks out `master` before running, so the `uv run` call here will always exit non-zero with "No such file or directory". The same applies to `tools/pr-approval-agent/dismiss_check.py` in the `decide-delta` job (line 187). Both scripts need to be merged to `master` before this workflow will function.
### Issue 2 of 2
.github/workflows/pr-approval-agent.yml:187
**Same missing-script issue in `decide-delta`**
`tools/pr-approval-agent/dismiss_check.py` is also absent from master. Because `decide-delta` has `set -euo pipefail`, the failure here causes the entire `decide-delta` job to fail, which in turn causes the `review` job's `needs.decide-delta.result == 'failure'` branch to fire — running a review job that then also fails for the same reason.
Reviews (1): Last reviewed commit: "Added stamphog to code" | Re-trigger Greptile |
Port the PR approval agent (gates, reviewer, dismiss-check, migration-risk) from PostHog/posthog into tools/pr-approval-agent/ so the existing pr-approval-agent workflow has the python it needs to run. Adapt for this repo: main default branch, PostHog/code default --repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes