Skip to content

revert(integrations): remove server-side kind filter (#1954)#2383

Merged
Twixes merged 1 commit into
mainfrom
revert/integrations-kind-filter
May 27, 2026
Merged

revert(integrations): remove server-side kind filter (#1954)#2383
Twixes merged 1 commit into
mainfrom
revert/integrations-kind-filter

Conversation

@Twixes
Copy link
Copy Markdown
Member

@Twixes Twixes commented May 26, 2026

Summary

Reverts #1954, which filtered integration API calls to GitHub only via a server-side ?kind=github query param.

That filtering broke Slack connection for inbox notifications (added in #2174) - PostHog Code no longer saw Slack integrations configured on the project because they were excluded from the API response.

Client-side filtering in integrationStore already handles per-kind selectors (githubIntegrations, slackIntegrations), so fetching all integrations is safe and restores Slack (and other) integration visibility.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 26, 2026

Reviews (1): Last reviewed commit: "Revert "feat(integrations): filter integ..." | Re-trigger Greptile

@Twixes Twixes requested review from VojtechBartos and skoob13 May 26, 2026 19:38
@Twixes Twixes merged commit b421fc5 into main May 27, 2026
15 checks passed
@Twixes Twixes deleted the revert/integrations-kind-filter branch May 27, 2026 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants