Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions apps/code/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@
"@phosphor-icons/react": "^2.1.10",
"@pierre/diffs": "^1.1.21",
"@posthog/agent": "workspace:*",
"@posthog/api-client": "workspace:*",
"@posthog/electron-trpc": "workspace:*",
"@posthog/enricher": "workspace:*",
"@posthog/git": "workspace:*",
Expand Down
9 changes: 7 additions & 2 deletions apps/code/src/renderer/api/posthogClient.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
import type { SpendAnalysisResponse } from "@features/billing/types/spend-analysis";
import { isSupportedReasoningEffort } from "@posthog/agent/adapters/reasoning-effort";
import type { PermissionMode } from "@posthog/agent/execution-mode";
import {
buildApiFetcher,
createApiClient,
type Schemas,
} from "@posthog/api-client";
import {
DISMISSAL_REASON_OPTIONS,
type DismissalReasonOptionValue,
Expand Down Expand Up @@ -36,8 +41,6 @@ import type { SeatData } from "@shared/types/seat";
import { SEAT_PRODUCT_KEY } from "@shared/types/seat";
import type { StoredLogEntry } from "@shared/types/session-events";
import { logger } from "@utils/logger";
import { buildApiFetcher } from "./fetcher";
import { createApiClient, type Schemas } from "./generated";

export class SeatSubscriptionRequiredError extends Error {
redirectUrl: string;
Expand Down Expand Up @@ -573,6 +576,8 @@ export class PostHogAPIClient {
buildApiFetcher({
getAccessToken,
refreshAccessToken,
appVersion:
typeof __APP_VERSION__ !== "undefined" ? __APP_VERSION__ : "unknown",
}),
baseUrl,
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import {
sessionStoreSetters,
useSessionStore,
} from "@features/sessions/stores/sessionStore";
import type { Schemas } from "@renderer/api/generated";
import type { Schemas } from "@posthog/api-client";
import type { Task } from "@shared/types";
import {
enrichDescriptionWithFileContent,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ import {
import { useTasks, useUpdateTask } from "@features/tasks/hooks/useTasks";
import { useWorkspaces } from "@features/workspace/hooks/useWorkspace";
import { useTaskContextMenu } from "@hooks/useTaskContextMenu";
import type { Schemas } from "@posthog/api-client";
import { ScrollArea, Separator } from "@posthog/quill";
import { Box, Flex } from "@radix-ui/themes";
import type { Schemas } from "@renderer/api/generated";
import { trpcClient } from "@renderer/trpc/client";
import type { Task } from "@shared/types";
import { useCommandMenuStore } from "@stores/commandMenuStore";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import {
useTasks,
} from "@features/tasks/hooks/useTasks";
import { useWorkspaces } from "@features/workspace/hooks/useWorkspace";
import type { Schemas } from "@renderer/api/generated";
import type { Schemas } from "@posthog/api-client";
import type { Task, TaskRunStatus } from "@shared/types";
import { useEffect, useMemo, useRef } from "react";
import { useSidebarStore } from "../stores/sidebarStore";
Expand Down
2 changes: 1 addition & 1 deletion apps/code/src/renderer/features/tasks/hooks/useTasks.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { workspaceApi } from "@features/workspace/hooks/useWorkspace";
import { useAuthenticatedMutation } from "@hooks/useAuthenticatedMutation";
import { useAuthenticatedQuery } from "@hooks/useAuthenticatedQuery";
import { useMeQuery } from "@hooks/useMeQuery";
import type { Schemas } from "@renderer/api/generated";
import type { Schemas } from "@posthog/api-client";
import { useFocusStore } from "@renderer/stores/focusStore";
import { useNavigationStore } from "@renderer/stores/navigationStore";
import { trpcClient } from "@renderer/trpc/client";
Expand Down
5 changes: 4 additions & 1 deletion biome.jsonc
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,10 @@
},
{
// API client generates a lot of Any and uses codegen-specific formatting
"includes": ["apps/code/src/renderer/api/generated.ts"],
"includes": [
"apps/code/src/renderer/api/generated.ts",
"packages/api-client/src/generated.ts"
],
"linter": {
"enabled": false
},
Expand Down
20 changes: 12 additions & 8 deletions packages/api-client/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,20 +4,24 @@
"description": "Client for the PostHog API (auth, projects, task metadata, billing). Pure HTTPS, runs in any JS environment. Constructed via factory function — no DI container.",
"private": true,
"type": "module",
"scripts": {
"clean": "node ../../scripts/rimraf.mjs dist .turbo"
"exports": {
".": "./src/index.ts",
"./*": [
"./src/*.ts",
"./src/*.tsx"
]
},
"dependencies": {
"@posthog/core": "workspace:*"
"scripts": {
"typecheck": "tsc --noEmit",
"test": "vitest run",
"clean": "node ../../scripts/rimraf.mjs .turbo"
},
"devDependencies": {
"@posthog/tsconfig": "workspace:*",
"@posthog/tsup-config": "workspace:*",
"tsup": "catalog:",
"typescript": "catalog:"
"typescript": "catalog:",
"vitest": "^2.1.9"
},
"files": [
"dist/**/*",
"src/**/*"
]
}
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,11 @@ describe("buildApiFetcher", () => {
const refreshAccessToken = vi.fn().mockResolvedValue("new-token");
mockFetch.mockResolvedValueOnce(ok());

const fetcher = buildApiFetcher({ getAccessToken, refreshAccessToken });
const fetcher = buildApiFetcher({
getAccessToken,
refreshAccessToken,
appVersion: "test",
});
await fetcher.fetch(mockInput);

expect(getAccessToken).toHaveBeenCalledTimes(1);
Expand All @@ -52,7 +56,11 @@ describe("buildApiFetcher", () => {
const refreshAccessToken = vi.fn().mockResolvedValue("new-token");
mockFetch.mockResolvedValueOnce(err(401)).mockResolvedValueOnce(ok());

const fetcher = buildApiFetcher({ getAccessToken, refreshAccessToken });
const fetcher = buildApiFetcher({
getAccessToken,
refreshAccessToken,
appVersion: "test",
});
const response = await fetcher.fetch(mockInput);

expect(response.ok).toBe(true);
Expand All @@ -68,7 +76,11 @@ describe("buildApiFetcher", () => {
const refreshAccessToken = vi.fn().mockResolvedValue("new-token");
mockFetch.mockResolvedValueOnce(err(403, { detail: "Permission denied." }));

const fetcher = buildApiFetcher({ getAccessToken, refreshAccessToken });
const fetcher = buildApiFetcher({
getAccessToken,
refreshAccessToken,
appVersion: "test",
});

await expect(fetcher.fetch(mockInput)).rejects.toThrow("[403]");
expect(getAccessToken).toHaveBeenCalledTimes(1);
Expand All @@ -88,7 +100,11 @@ describe("buildApiFetcher", () => {
)
.mockResolvedValueOnce(ok());

const fetcher = buildApiFetcher({ getAccessToken, refreshAccessToken });
const fetcher = buildApiFetcher({
getAccessToken,
refreshAccessToken,
appVersion: "test",
});
const response = await fetcher.fetch(mockInput);

expect(response.ok).toBe(true);
Expand All @@ -105,6 +121,7 @@ describe("buildApiFetcher", () => {
const fetcher = buildApiFetcher({
getAccessToken: vi.fn().mockResolvedValue("token"),
refreshAccessToken,
appVersion: "test",
});

await expect(fetcher.fetch(mockInput)).rejects.toThrow("[400]");
Expand All @@ -116,7 +133,11 @@ describe("buildApiFetcher", () => {
const refreshAccessToken = vi.fn().mockResolvedValue("token-2");
mockFetch.mockResolvedValueOnce(err(401)).mockResolvedValueOnce(err(401));

const fetcher = buildApiFetcher({ getAccessToken, refreshAccessToken });
const fetcher = buildApiFetcher({
getAccessToken,
refreshAccessToken,
appVersion: "test",
});

await expect(fetcher.fetch(mockInput)).rejects.toThrow("[401]");
});
Expand All @@ -128,7 +149,11 @@ describe("buildApiFetcher", () => {
.mockRejectedValueOnce(new Error("failed"));
mockFetch.mockResolvedValueOnce(err(401));

const fetcher = buildApiFetcher({ getAccessToken, refreshAccessToken });
const fetcher = buildApiFetcher({
getAccessToken,
refreshAccessToken,
appVersion: "test",
});

await expect(fetcher.fetch(mockInput)).rejects.toThrow("[401]");
});
Expand All @@ -138,6 +163,7 @@ describe("buildApiFetcher", () => {
const fetcher = buildApiFetcher({
getAccessToken: vi.fn().mockResolvedValue("token"),
refreshAccessToken: vi.fn().mockResolvedValue("new-token"),
appVersion: "test",
});

await expect(fetcher.fetch(mockInput)).rejects.toThrow(
Expand Down
Original file line number Diff line number Diff line change
@@ -1,19 +1,24 @@
import type { createApiClient } from "./generated";

const USER_AGENT = `posthog/desktop.hog.dev; version: ${typeof __APP_VERSION__ !== "undefined" ? __APP_VERSION__ : "unknown"}`;

export const buildApiFetcher: (config: {
export type ApiFetcherConfig = {
getAccessToken: () => Promise<string>;
refreshAccessToken: () => Promise<string>;
}) => Parameters<typeof createApiClient>[0] = (config) => {
appVersion: string;
};

export const buildApiFetcher: (
config: ApiFetcherConfig,
) => Parameters<typeof createApiClient>[0] = (config) => {
const userAgent = `posthog/desktop.hog.dev; version: ${config.appVersion}`;

const makeRequest = async (
input: Parameters<Parameters<typeof createApiClient>[0]["fetch"]>[0],
token: string,
): Promise<Response> => {
const headers = new Headers();
headers.set("Authorization", `Bearer ${token}`);
headers.set("Content-Type", "application/json");
headers.set("User-Agent", USER_AGENT);
headers.set("User-Agent", userAgent);

if (input.urlSearchParams) {
input.url.search = input.urlSearchParams.toString();
Expand Down Expand Up @@ -56,7 +61,10 @@ export const buildApiFetcher: (config: {
if (response.status === 401) return true;
if (response.status !== 403) return false;
try {
const body = await response.clone().json();
const body = (await response.clone().json()) as {
code?: string;
type?: string;
} | null;
return (
body?.code === "authentication_failed" ||
body?.type === "authentication_error"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
import type { Schemas } from "./generated";

// typed-openapi omits the `Schemas.` prefix when referencing
// underscore-prefixed schema types from query-parameter positions inside
// the Endpoints namespace. Re-declare them as members of Endpoints so the
// unqualified references in `generated.ts` resolve via declaration merging.
declare module "./generated" {
namespace Endpoints {
type _DateRange = Schemas._DateRange;
type _LogPropertyFilter = Schemas._LogPropertyFilter;
type _DateRange = import("./generated").Schemas._DateRange;
type _LogPropertyFilter = import("./generated").Schemas._LogPropertyFilter;
}
}

export {};
4 changes: 4 additions & 0 deletions packages/api-client/src/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
import "./generated.augment";

export { type ApiFetcherConfig, buildApiFetcher } from "./fetcher";
export { createApiClient, type Schemas } from "./generated";
16 changes: 6 additions & 10 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading