-
Notifications
You must be signed in to change notification settings - Fork 31
feat(mobile): show prompt in chat thread immediately on submit #2407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
71 changes: 71 additions & 0 deletions
71
apps/mobile/src/features/tasks/stores/pendingTaskPromptStore.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| import { beforeEach, describe, expect, it } from "vitest"; | ||
| import { | ||
| pendingTaskPromptStoreApi, | ||
| usePendingTaskPromptStore, | ||
| } from "./pendingTaskPromptStore"; | ||
|
|
||
| describe("pendingTaskPromptStore", () => { | ||
| beforeEach(() => { | ||
| usePendingTaskPromptStore.setState({ byKey: {} }); | ||
| }); | ||
|
|
||
| it("stores prompts keyed by an arbitrary id", () => { | ||
| pendingTaskPromptStoreApi.set("uuid-1", { | ||
| promptText: "Fix the login bug", | ||
| setAt: 1000, | ||
| }); | ||
|
|
||
| expect(pendingTaskPromptStoreApi.get("uuid-1")).toEqual({ | ||
| promptText: "Fix the login bug", | ||
| setAt: 1000, | ||
| }); | ||
| }); | ||
|
|
||
| it("moves a prompt from a transient key to the real task id", () => { | ||
| pendingTaskPromptStoreApi.set("uuid-1", { | ||
| promptText: "Do the thing", | ||
| setAt: 1000, | ||
| }); | ||
| pendingTaskPromptStoreApi.move("uuid-1", "task-123"); | ||
|
|
||
| expect(pendingTaskPromptStoreApi.get("uuid-1")).toBeUndefined(); | ||
| expect(pendingTaskPromptStoreApi.get("task-123")).toEqual({ | ||
| promptText: "Do the thing", | ||
| setAt: 1000, | ||
| }); | ||
| }); | ||
|
|
||
| it("ignores move when the source key has no prompt", () => { | ||
| pendingTaskPromptStoreApi.move("missing", "task-999"); | ||
| expect(pendingTaskPromptStoreApi.get("task-999")).toBeUndefined(); | ||
| }); | ||
|
|
||
| it("clears prompts", () => { | ||
| pendingTaskPromptStoreApi.set("task-42", { | ||
| promptText: "Hi", | ||
| setAt: 1000, | ||
| }); | ||
| pendingTaskPromptStoreApi.clear("task-42"); | ||
| expect(pendingTaskPromptStoreApi.get("task-42")).toBeUndefined(); | ||
| }); | ||
|
|
||
| it("preserves attachments through move", () => { | ||
| pendingTaskPromptStoreApi.set("uuid-1", { | ||
| promptText: "Look at this", | ||
| setAt: 1000, | ||
| attachments: [ | ||
| { | ||
| kind: "image", | ||
| uri: "file://x.png", | ||
| fileName: "x.png", | ||
| mimeType: "image/png", | ||
| }, | ||
| ], | ||
| }); | ||
| pendingTaskPromptStoreApi.move("uuid-1", "task-7"); | ||
|
|
||
| expect(pendingTaskPromptStoreApi.get("task-7")?.attachments).toHaveLength( | ||
| 1, | ||
| ); | ||
| }); | ||
| }); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alreadyEchoedchecksm.content === optimisticUserMessage.textbut never compares attachments. For a message that is attachment-only (emptytext) or a session that already contains a previous user turn with the same text, the condition fires immediately and the optimistic echo is dropped before the real SSE copy arrives. In practice this mostly matters for attachment-only submissions (content === ""on both sides) if more than one such message exists inmessages, but the logic gap means any text-identical historical user message would also suppress the optimistic echo incorrectly.Prompt To Fix With AI