Skip to content

security: fix SnakeYAML deserialization vulnerability in JDBC tests #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fuziontech merged 1 commit into from
Apr 23, 2026
Merged

security: fix SnakeYAML deserialization vulnerability in JDBC tests #454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@ certs/
*.swp
*.swo

# Dashboard UI
dashboard/ui/node_modules/
dashboard/ui/.svelte-kit/

# OS
.DS_Store
Thumbs.db
Expand Down
4 changes: 3 additions & 1 deletion scripts/client-compat/clients/jdbc/src/main/java/com/duckgres/compat/JdbcCompatTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,9 @@
import java.sql.*;
import java.util.*;

import org.yaml.snakeyaml.LoaderOptions;
import org.yaml.snakeyaml.Yaml;
import org.yaml.snakeyaml.constructor.SafeConstructor;

public class JdbcCompatTest {

Expand Down Expand Up @@ -112,7 +114,7 @@ private static void waitForDuckgres() throws Exception {
@SuppressWarnings("unchecked")
private static List<Map<String, Object>> loadQueries(String path) throws Exception {
String content = Files.readString(Path.of(path));
Yaml yaml = new Yaml();
Yaml yaml = new Yaml(new SafeConstructor(new LoaderOptions()));
return yaml.load(content);
}

Expand Down
4 changes: 3 additions & 1 deletion scripts/client-compat/clients/jdbc/src/main/java/com/posthog/compat/JdbcCompatTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
package com.posthog.compat;

import org.yaml.snakeyaml.LoaderOptions;
import org.yaml.snakeyaml.Yaml;
import org.yaml.snakeyaml.constructor.SafeConstructor;

import java.io.IOException;
import java.io.InputStream;
Expand Down Expand Up @@ -345,7 +347,7 @@ private void runRepeatedScalarQuery(String sql, String testName, int iterations)
}

private static List<Map<String, Object>> loadQueries(String path) throws IOException {
Yaml yaml = new Yaml();
Yaml yaml = new Yaml(new SafeConstructor(new LoaderOptions()));
try (InputStream in = Files.newInputStream(Path.of(path))) {
Object loaded = yaml.load(in);
if (!(loaded instanceof List<?> list)) {
Expand Down
Loading