Open
Conversation
dustinbyrne
force-pushed
the
feat/get-feature-flag-result
branch
from
6458f44 to
7bf8fa6
Compare
Author
|
CI will fail until PostHog/posthog-ios#459 is released |
dustinbyrne
changed the title
getFeatureFlagPayload APIgetFeatureFlagResult API
dustinbyrne
force-pushed
the
feat/get-feature-flag-result
branch
from
7bf8fa6 to
483265d
Compare
marandaneto
reviewed
Feb 9, 2026
| result: Result, | ||
| ) { | ||
| try { | ||
| val featureFlagKey: String = call.argument("key")!! |
Member
There was a problem hiding this comment.
do not use !! otherwise the app will crash, either fallback to empty or return early
marandaneto
reviewed
Feb 9, 2026
| /// - `String`: Multivariate flag with the given variant | ||
| factory PostHogFeatureFlagResult.fromValueAndPayload( | ||
| String key, | ||
| Object? flagValue, |
marandaneto
reviewed
Feb 9, 2026
| other.key == key && | ||
| other.enabled == enabled && | ||
| other.variant == variant && | ||
| other.payload == payload; |
Member
There was a problem hiding this comment.
this is not doing deep equality, should we?
you can check PHListEquality().equals(...) if payload is a collection
marandaneto
approved these changes
Feb 9, 2026
Member
marandaneto
left a comment
marandaneto
left a comment
There was a problem hiding this comment.
left a few comments otherwise LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Add a
getFeatureFlagResultAPI that returns a unifiedPostHogFeatureFlagResultobject containing the flag key, enabled state, variant (for multivariate flags), and payload in a single call. Previously, getting full flag information required separate calls togetFeatureFlagandgetFeatureFlagPayload. This also supports asendEventparameter to suppress the$feature_flag_calledevent when only the payload is needed.getFeatureFlagPayloadis now deprecated in favor of this new method.💚 How did you test it?
PostHogFeatureFlagResult(fromValueAndPayload,fromMap,equality,toString, null/edge cases)sendEventparameter forwardinggetFeatureFlagResult📝 Checklist