fix(quill): smaller changes, more consistent, more stable#54375
fix(quill): smaller changes, more consistent, more stable#54375adamleithp merged 10 commits intomasterfrom
Conversation
@posthog/quill-tokens@0.1.0-alpha.2 is already on npm, which was blocking republish with a 403. Bump both @posthog/quill and @posthog/quill-tokens to 0.1.0-alpha.3 so the next workflow run has a fresh version to publish. Also add `stamphog` as a third option on the workflow_dispatch `tag` input so the publish workflow can target that dist-tag. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
le again, re-work fill-* colors to be neutral particularly fill-hover
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
Prompt To Fix All With AIThis is a comment left during a code review.
Path: packages/quill/packages/primitives/src/button.stories.tsx
Line: 45
Comment:
**Incorrect label on disabled button**
The button in the first `<div>` is rendered `disabled` but labeled `"Selected"` — the second `<div>` correctly uses `"Disabled"`. This makes the story misleading when comparing the two backgrounds side-by-side.
```suggestion
<Button disabled>Disabled</Button>
```
How can I resolve this? If you propose a fix, please make it concise.
---
This is a comment left during a code review.
Path: packages/quill/apps/storybook/.storybook/main.ts
Line: 19-34
Comment:
**Pending rebuild dropped when a change arrives during an active rebuild**
If a token file is saved while `rebuilding` is `true`, the debounce timer fires 100 ms later, `rebuild()` returns early, and the pending change is silently lost. The developer must save the file again to pick up the change.
A simple fix is to queue one deferred rebuild:
```typescript
const rebuild = (server: ViteDevServer): void => {
if (rebuilding) {
rebuildPending = true
return
}
rebuildPending = false
rebuilding = true
const proc = spawn('pnpm', ['exec', 'tsx', 'src/build.ts'], {
cwd: tokensRoot,
stdio: 'inherit',
shell: true,
})
proc.on('exit', (code) => {
rebuilding = false
if (code === 0) {
server.ws.send({ type: 'full-reload' })
}
if (rebuildPending) {
rebuild(server)
}
})
}
```
(Also declare `let rebuildPending = false` alongside `let rebuilding = false`.)
How can I resolve this? If you propose a fix, please make it concise.Reviews (1): Last reviewed commit: "formatting" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
![stamphog[bot]](https://avatars.githubusercontent.com/in/3000332?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
adamleithp
changed the title
2 participants
Problem
Fixing some inconsistencies
Changes
Too many
How did you test this code?
No