Open
Conversation
…tatic file caching; remove sync-over-async in controller; reduce CPU spin in Power BI import polling; fix minor token typo; optimize React build config with production mode and code splitting. Why: Smaller responses and better caching reduce load times; avoiding .Result prevents thread pool starvation; sleeping in polling loops reduces CPU; production webpack build yields smaller bundles.
…open-source-contribution-d652 Optimize code for open source contribution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimizations were applied across the codebase:
ASP.NET apps (Startup.cs in Admin, Client, WebApi) now use response compression and static file caching for faster loads.
HomeController.Embed and PowerBiServiceApi.GetAccessToken were made async to remove .Result and prevent deadlocks.
Thread.Sleep was added to Power BI import polling in PowerBiServiceApi.cs to reduce CPU usage.
The React client's webpack.config.js and package.json were updated for optimized production builds.
A typo in TokenManager.cs and duplicate using statements were corrected.