Go: upgrade to 1.26, dependencies, golangci-lint#134
Open
ahouene wants to merge 1 commit intoPowerDNS:mainfrom
Open
Go: upgrade to 1.26, dependencies, golangci-lint#134ahouene wants to merge 1 commit intoPowerDNS:mainfrom
ahouene wants to merge 1 commit intoPowerDNS:mainfrom
Conversation
This was referenced Mar 17, 2026
Luit
reviewed
Mar 18, 2026
| go 1.25.0 | ||
|
|
||
| toolchain go1.25.6 | ||
| toolchain go1.26.1 |
Contributor
There was a problem hiding this comment.
I think this requires someone with Go 1.25 to run with GOTOOLCHAIN=auto, which may not be the default for packaged Go (I think on Fedora it's not). Would it be better to make this go1.25.0 as well? That's the stated minimum supported version. I'm not sure a library should enforce specific patch versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply most upgrades available. This excludes an upgrade for the Azurite SDK (v1.6.4, current is v1.6.3) that is for now complaining about the Azurite Docker image used not being compatible.