feat: enhance NPC and Skin management with subfolder support & add PNX 3.0.0 support#1
Open
TraxTRL wants to merge 14 commits into
Open
feat: enhance NPC and Skin management with subfolder support & add PNX 3.0.0 support#1TraxTRL wants to merge 14 commits into
TraxTRL wants to merge 14 commits into
Conversation
Load NPC and skin files recursively from subdirectories so they can be organized into folders. NPCs and skins are now keyed by their path relative to their root (e.g. shops/blacksmith), so same-named files in different folders no longer collide. Skin directories containing skin.png/skin_slim.png are still treated as 4D skins; other directories are organizational. Track each NPC's source file so deletion works for NPCs in subfolders, and let /rsnpc create accept a subfolder/name path (creating parent directories and using the leaf as the display name). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Replace the stub README with an English guide covering features, commands, permissions, in-game menus, folder layout, NPC config fields, skins, dialog pages, and placeholders. Documents the subfolder / path-based naming for Npcs and Skins, and credits the original MemoriesOfTime founding authors (SmallasWater, LT_Name) as a fork. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Translate javadoc and inline comments across the source to English. Leaves user-facing strings, log messages, chs-only flavor text, built-in skin filenames, and legacy migration config keys unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
updateRsNPC2_0_0_To_RsNPC2_2_3 listed Npcs non-recursively and its skip guard never excluded directories, so with subfolder organization it tried to open/save each subfolder as a YAML config, spamming FileNotFoundException / "Is a directory" errors on enable. Recurse into subdirectories and only process .yml files. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
TraxTRL
marked this pull request as draft
July 11, 2026 23:31
Author
|
Need to fix a bug - somehow an NPC got saved to a chunk |
TraxTRL
marked this pull request as ready for review
July 18, 2026 17:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for PNX API 3.0.0, allows subfolders in NPC and Skin folder and adds a new overhauled README which showcases all the features RsNPC offers.
Note
Claude Opus 4.8 was used for: