Cmdlets should respect SwitchParameter values not presence alone #1925
+29
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some parameter switches like
-WhatIf,-PSGalleryfor certain cmdlets were not being checked and used logically in the correct manner. The previous code was simply checking if the parameter switch was supplied and if so, equating that to the value of the parameter switch being true. This meant that in a scenario like,-WhatIf:$falsethe code detected presence of the-WhatIfparameter and did not install the package. Now, switch parameter values are checked. For-PSGalleryswitch parameter inRegister-PSResourceRepositoryproviding-PSGallery:$falsewill mean PSGallery is not registered and no error is reported.PR Summary
PR Context
Resolves #1805
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.