UX/A11y: Replace empty href=# attributes with valid actions#3896
Open
pradeep0153 wants to merge 1 commit into
Open
UX/A11y: Replace empty href=# attributes with valid actions#3896pradeep0153 wants to merge 1 commit into
pradeep0153 wants to merge 1 commit into
Conversation
|
@pradeep0153 Your PR doesn't have any code changes, so I'm unable to review it. Could you please check and update it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3894.
Description
This PR resolves a frustrating User Experience (UX) flaw where interacting with certain visual links caused the browser to aggressively snap to the top of the webpage.
Changes Made
<a>) utilizing an empty hash fragment (href="#") that were intended to trigger JavaScript events rather than perform navigation.href="javascript:void(0)"(or refactored them to<button type="button">) to neutralize the default anchor behavior while completely preserving the element's stylings and interactivity.Impact