Fix/issue 3890 list keys#3903
Open
pradeep0153 wants to merge 27 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3890.
Description
This PR resolves an underlying React rendering issue where multiple
.map()functions were dynamically generating lists of elements without assigning a uniquekeyprop to the top-level returned node.Changes Made
keyprops (preferring unique database IDs or data-specific identifiers over simple array indices) into the dynamically rendered elements.Impact
keyprop to identify which items have changed, been added, or been removed during the reconciliation phase. Missing keys lead to unnecessary full DOM re-renders, annoying console warnings, and potential UI bugs where component states (like open/closed toggles or input values) get mixed up between siblings during list updates.